Stop adding BUFFET_MONITORING to configs written by SU2_PY - #2905
Open
ManasBagul23 wants to merge 1 commit into
Open
ManasBagul23 wants to merge 1 commit into
ManasBagul23 wants to merge 1 commit into
Conversation
BUFFET_MONITORING was removed from CConfig, and the buffet sensor is now always evaluated for viscous problems. read_config still set it to YES whenever BUFFET was an objective or constraint, and dump_config writes every key, so SU2_CFD aborted on the generated config with "BUFFET_MONITORING: invalid option name".
There was a problem hiding this comment.
🟡 Changes recommended
The standard template can still cause invalid BUFFET_MONITORING output.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
This PR stops SU2_PY from adding the obsolete BUFFET_MONITORING option to generated configurations.
Changes:
- Removes automatic insertion for buffet objectives and constraints.
- The stale template option still needs removal or filtering.
File summaries
| File | Summary |
|---|---|
SU2_PY/SU2/io/config.py |
Removes obsolete buffet-monitoring option generation. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| if "BUFFET" in data_dict["OPT_OBJECTIVE"]: | ||
| data_dict["BUFFET_MONITORING"] = "YES" | ||
|
|
||
| # hack - twl |
Author
There was a problem hiding this comment.
The stale BUFFET_MONITORING= NO line in config_template.cfg is removed in #2904, together with the other options that no longer parse.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
BUFFET_MONITORINGwas removed from CConfig and the buffet sensor is now always evaluated for viscous problems.read_configinSU2_PY/SU2/io/config.pystill setsBUFFET_MONITORING= YESwhenBUFFETis an objective or constraint, anddump_configwrites every key, so the config handed toSU2_CFDaborts with:Reproduced by loading a Navier-Stokes config with
OPT_OBJECTIVE= BUFFET * 1.0throughSU2.io.Config, dumping it and runningSU2_CFD -don the result. With this change the dumped config parses.Related Work
None.
PR Checklist
pre-commit run --allto format old commits.