Repository navigation
chore(deps): bump substrait packages to 0.101.0 - #288
Conversation
Bumps substrait-protobuf, substrait-extensions, and substrait-antlr to spec v0.101.0. - UpdateRel now carries a RelCommon. A correlation into an UpdateRel binding is now anchored by to_id_based_outer_references instead of raising, and DataFrame.hint(...) can annotate an UpdateRel. ReferenceRel is now the only relation without a RelCommon; the converter's no-RelCommon guard is kept for a Rel with no relation set. - OuterReference.steps_out is deprecated in favour of rel_reference. No change needed: inference already resolves both forms, and the DataFrame layer already emits rel_reference. The lower-level outer() expression builder still produces steps_out, which remains valid. - extension_types.yaml and type_variations.yaml leave the extension catalog. The default registry only loads functions*.yaml, so nothing here depended on them.
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
⛔ Files ignored due to path filters (2)
📒 Files selected for processing (4)
Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 SummarySummary by CodeRabbit
WalkthroughDependency pins are updated to Substrait 0.101.0. Documentation comments and tests now reflect that ChangesSubstrait 0.101.0 update
Priority: ➖ Normal Estimated code review effort: 2 (Simple) | ~10 minutes Change: Other Suggested reviewers: Merge Risk: ⚪ Minimal · up to The dependency update aligns the project with Substrait 0.101.0, and the inspected hint and correlation-reference paths use UpdateRel’s new RelCommon. No actionable merge-blocking issue is evident; proceed with normal checks. Security Architecture ReviewSecurity architecture risk: 🔵 Low · up to The inspected changes remain within plan construction and preserve existing guards and failure isolation. No introduced security vulnerability was established, but compatibility with the external generated schema and downstream execution engines remains unverified. Retained concerns Security review detailsSecurity Blast Radius
Trust Boundaries and Controls
Resilience and Maintainability Implications
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Docstring CoverageExplanation Docstring coverage is 33.33% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 6 functions across 3 files. (1 skipped: 1 unsupported.)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Closes #253.
Bumps
substrait-protobuf,substrait-extensions, andsubstrait-antlrto spec v0.101.0 (release notes).UpdateRelnow carries aRelCommon. A correlation into anUpdateRelbinding is now anchored byto_id_based_outer_referencesinstead of raising, andDataFrame.hint(...)can annotate anUpdateRel.ReferenceRelis now the only relation without aRelCommon; the converter's no-RelCommonguard is kept for aRelwith no relation set.OuterReference.steps_outis deprecated in favour ofrel_reference. No change needed: inference already resolves both forms, and the DataFrame layer already emitsrel_reference. The lower-levelouter()expression builder still producessteps_out, which remains valid.extension_types.yamlandtype_variations.yamlleave the extension catalog. The default registry only loadsfunctions*.yaml, so nothing here depended on them.🤖 Generated with AI