Skip to content

chore: unpin duckdb - #296

Open
tokoko wants to merge 3 commits into
substrait-io:mainfrom
tokoko:chore/unpin-duckdb
Open

tokoko wants to merge 3 commits into
substrait-io:mainfrom
tokoko:chore/unpin-duckdb

Conversation

@tokoko

@tokoko tokoko commented Oct 8, 2026

Copy link
Copy Markdown
Contributor

drops the duckdb version pin from dev dependencies.

@coderabbitai

coderabbitai Bot commented Oct 8, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 48 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration
  • Configuration used: Repository: substrait-io/substrait-python/.coderabbit.yaml
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 8e473e82-d3a9-45a7-84e5-170ef3c2493e
📥 Commits

Reviewing files that changed from the base of the PR and between a6aa7c6 and eb9b4a8.

⛔ Files ignored due to path filters (2)
  • pixi.lock is excluded by !**/*.lock
  • uv.lock is excluded by !**/*.lock
📒 Files selected for processing (3)
  • examples/duckdb_example.py
  • pyproject.toml
  • tests/integration/test_sql_engine_roundtrip.py

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Repository: substrait-io/substrait-python/.coderabbit.yaml
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 2f823242-ac13-4362-95e9-e1731f46c462
📥 Commits

Reviewing files that changed from the base of the PR and between 3908dac and a6aa7c6.

⛔ Files ignored due to path filters (2)
  • pixi.lock is excluded by !**/*.lock
  • uv.lock is excluded by !**/*.lock
📒 Files selected for processing (3)
  • examples/duckdb_example.py
  • pyproject.toml
  • tests/integration/test_sql_engine_roundtrip.py

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Summary

Summary by CodeRabbit

  • Tests
    • Expanded DuckDB integration coverage for retrieving schemas and query results, creating tables from test data, and checking limited queries across supported engines.

Walkthrough

The example and development dependency declarations update DuckDB versions or constraints. The integration tests use to_arrow_table(), create tables from test data, and include DuckDB through the engines parameterization.

Changes

DuckDB Updates

Layer / File(s) Summary
Update DuckDB dependency declarations
examples/duckdb_example.py, pyproject.toml
The example pins DuckDB to version 1.5.6. The development dependency no longer has a version or Python-version constraint.
Update DuckDB integration tests
tests/integration/test_sql_engine_roundtrip.py
The tests use to_arrow_table() for schema and result conversion, create stores and sales tables from test data, and use engines instead of engines_duckdb_xfail for the affected tests.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Other

Suggested reviewers: nielspardon

Merge Risk: ⚪ Minimal · up to a6aa7

CI remains reproducible and the DuckDB integration updates are compatible with the locked version.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 5 functions across 2 files. (1 skipped: 1 … Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title is concise, uses a valid Conventional Commit format, and accurately describes the main change: removing the DuckDB version pin.
Description check ✅ Passed The description states the main rationale and matches the pull request changes. It is brief but sufficient for this low-risk dependency update.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 5 functions across 2 files. (1 skipped: 1 unsupported.)

✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Create a new PR
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

tokoko added 2 commits October 8, 2026 21:52
… into chore/unpin-duckdb

# Conflicts:
#	pixi.lock
#	pyproject.toml

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant