feat(cli): add experimental stack logs - #6510
Open
jgoux wants to merge 8 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
🤖 AI Review
Only Claude's independent review was available; the Codex review did not complete. After checking every claim against the PR tree and trusted conventions, eight findings are confirmed and one is refuted. No critical or major defects were found; the principal concerns are incomplete branch coverage, a declared stack error misclassified as unknown telemetry, and incomplete compatibility documentation.
Findings
| Severity | Location | Category | Sources | Claim |
|---|---|---|---|---|
| 🟡 MINOR | apps/cli/src/commands/experimental/stack/logs/logs.integration.test.ts:145 |
test-coverage |
claude | The integration suite leaves multiple handler and error-classification branches uncovered, contrary to the trusted requirement for 100% command-handler branch coverage. |
| 🟡 MINOR | apps/cli/src/commands/experimental/stack/logs/logs.handler.ts:54 |
error-handling |
claude | StackRuntimeMismatchError is a declared openStack failure but falls through to the unknown telemetry classification. |
| 🟡 MINOR | apps/cli/src/commands/experimental/stack/logs/SIDE_EFFECTS.md:15 |
documentation |
claude | SIDE_EFFECTS.md omits required exit-code documentation and does not document legacy output-flag rejection or the different outcomes for an absent default stack and a missing named stack. |
| ⚪ NIT | apps/cli/src/command-internal/legacy-db-target-flags.ts:80 |
maintainability |
claude | The service flag is placed under the db-family provenance comment even though it belongs to experimental stack logs. |
| ⚪ NIT | apps/cli/src/commands/experimental/stack/logs/logs.command.ts:30 |
consistency |
claude | The new --follow flag lacks the -f alias provided by the sibling experimental workers logs command. |
| ⚪ NIT | apps/cli/src/commands/experimental/stack/logs/logs.handler.ts:140 |
maintainability |
claude | The non-follow path duplicates emitEntries rendering logic, and the synthesized stack-id target carries an unused projectRoot field. |
| ⚪ NIT | apps/cli/src/commands/experimental/stack/logs/logs.command.ts:22 |
consistency |
claude | The tail limit is duplicated as literals and the flag description does not explain that zero skips retained history. |
| ⚪ NIT | apps/cli/src/shared/output/types.ts:14 |
documentation |
claude | The shared log-entry stream enum now permits internal, but the new machine-readable value is not documented for consumers. |
Refuted findings (kept for transparency, not posted as review comments)
apps/cli/src/commands/experimental/stack/logs/logs.handler.ts:128(output-contract): The found and not-found success payloads are improperly inconsistent because cursor and running are absent when no stack exists.
Refuted: The payload is intentionally discriminated by found. Cursor, running, and id describe an existing stack and are inapplicable when found is false; the sibling stack stop handler provides concrete counter-evidence that sparse no-stack results are the established shape. Missing documentation is covered separately.
Stats
Claude findings: 9 · Codex findings: 0 · Confirmed: 8 · Refuted: 1 · Uncertain: 0
Models: claude-opus-5 + gpt-5.6-sol · Trigger: auto · Workflow run
This review runs once per PR. A maintainer can request another with a /ai-review comment.
jgoux
force-pushed
the
feat/experimental-stack-logs
branch
from
September 8, 2026 05:31
d74dc21 to
225892e
Compare
jgoux
force-pushed
the
feat/experimental-stack-logs
branch
from
September 8, 2026 06:02
225892e to
0a37784
Compare
jgoux
force-pushed
the
feat/experimental-stack-logs
branch
from
September 8, 2026 12:32
0a37784 to
ee53c9d
Compare
Contributor
Supabase CLI previewnpx --yes https://pkg.pr.new/supabase/cli/supabase@ee53c9df5dd73a429b90f4ca9a11f81757b4d011Preview package for commit |
Contributor
Author
|
/ai-review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
supabase experimental stack logsreads the selected stack’s logs with service filtering, a bounded tail, and live following. Interrupting a log follower leaves the stack running.Support text and structured output, with stream-json for live machine consumers. This PR builds on experimental stack list (#6509).