ci(repo): publish preview packages only with run-preview-packages label - #6524
Queued
avallete wants to merge 2 commits into
Queued
ci(repo): publish preview packages only with run-preview-packages label#6524avallete wants to merge 2 commits into
avallete wants to merge 2 commits into
Conversation
Stop uploading large CLI binaries to pkg.pr.new on every develop PR; opt in with the label instead, and decouple preview from run-ci.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
🤖 AI Review
Claude reported three findings; Codex reported none. Code inspection confirms two low-impact hygiene issues. The possible required-check regression remains uncertain because branch-protection configuration is not present in the repository. No critical or major issues were verified.
Findings
| Severity | Location | Category | Sources | Claim |
|---|---|---|---|---|
| 🟡 MINOR | .github/workflows/publish-preview-cli-packages.yml:38 |
ci |
claude | Label-gating the reusable build job may leave a required nested preview-workflow check pending on unlabeled PRs if branch protection requires that check. |
| ⚪ NIT | .github/workflows/publish-preview-cli-packages.yml:54 |
maintainability |
claude | The label gate is redundantly duplicated in the downstream publish and comment jobs even though each already requires its gated upstream job to succeed. |
| ⚪ NIT | .github/workflows/run-ci.yml:24 |
security |
claude | run-ci.yml retains an unnecessary workflow-level pull-requests: write permission after removal of the preview job. |
Findings outside the diff
- ⚪ NIT
.github/workflows/run-ci.yml:24—run-ci.ymlretains an unnecessary workflow-levelpull-requests: writepermission after removal of the preview job.
Stats
Claude findings: 3 · Codex findings: 0 · Confirmed: 2 · Refuted: 0 · Uncertain: 1
Models: claude-opus-5 + gpt-5.6-sol · Trigger: auto · Workflow run
This review runs once per PR. A maintainer can request another with a /ai-review comment.
Coly010
approved these changes
Sep 8, 2026
Keep the opt-in gate only on the build job and remove pull-requests:write from run-ci now that it no longer posts preview comments.
avallete
added this pull request to the merge queue
Sep 8, 2026
Any commits made after this event will not be merged.
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Sep 8, 2026
avallete
added this pull request to the merge queue
Sep 9, 2026
Any commits made after this event will not be merged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pkg.pr.newpreview CLI package publishes behind therun-preview-packageslabel (re-publish on push while labeled; remove label to cancel).developPR and remove preview from therun-cisuite so large binaries are only uploaded when someone needs a shareable install.MAINTAINERS.mdand sync related workflow comments.Linked issue
No linked GitHub issue (maintainer follow-up from Slack).
open-for-contributionlabel (or I'm a Supabase maintainer).Checklist
fix(cli): …).pnpm check:allpasses; relevant package tests pass for every touched workspace, andpnpm types:checkpasses for each touched TypeScript workspace (or workspace declaring it).