Repository navigation
fix(combobox): ignore selection when disabled while open - #3917
Open
Xapollon430 wants to merge 1 commit into
Open
Xapollon430 wants to merge 1 commit into
Xapollon430 wants to merge 1 commit into
Conversation
|
@Xapollon430 is attempting to deploy a commit to the Tailwind Labs Team on Vercel. A member of the Team first needs to authorize it. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An already-open Combobox still accepts a pointer selection after its parent becomes disabled. This affects both the React and Vue Combobox implementations.
Each option now includes the Combobox's effective disabled state in its own interaction and accessibility state. The same click preserves Apple, emits no update, and the option is exposed as disabled.
Before and after video
The new regression fails in React and Vue before the change. After the fix, both Combobox suites pass (544 tests, 8 existing skips), along with scoped formatting. This is the Combobox path; #3912 covers Listbox.