Skip to content

Block pull requests without a cross-SDK parity decision - #102

Open
brionmario wants to merge 1 commit into
thunder-id:mainfrom
brionmario:sdk-parity-check
Open

brionmario wants to merge 1 commit into
thunder-id:mainfrom
brionmario:sdk-parity-check

Conversation

@brionmario

@brionmario brionmario commented Sep 15, 2026

Copy link
Copy Markdown
Member

Purpose

A capability that ships here usually has to ship in the other ThunderID SDKs too, and until now nothing at review time asked whether it did. The SDK development specification states that the parity decision is made on every pull request; this wires that up, as the second half of the proposal in thunder-id/thunderid#5354.

Approach

Every pull request must carry exactly one of parity/prs-raised or parity/prs-not-needed. The check stays red until it does, and a label is the only thing that clears it, so a change is never waved through on the strength of the files it happened to touch. Applying the label re-runs the check, so it goes green without a push.

Alongside the gate, the check keeps a single comment listing the sibling SDK repositories and ticks the boxes itself as port links appear in the pull request body or in replies on the thread, so nobody maintains that list by hand.

The logic lives in thunder-id/.github and is shared by all four SDK repositories, which cannot drift as a result. This file owns only the triggers, which a reusable workflow cannot declare for its caller, and passes nothing: the sibling list is derived from the repository the check runs in.

The pull request template gains the matching line.

Testing

The shared workflow was exercised against a stubbed github-script environment and then dry run end to end on a throwaway pull request, which confirmed it blocks the pull request red with the checklist comment, goes green the moment the label is applied without a push, and updates its comment in place rather than posting again. Details in thunder-id/.github#3.

Related Issues

Related PRs

Notes for merging

  • The two labels have to exist in this repository, or the gate cannot be cleared.
  • The required check to add to branch protection is 🔀 Cross-SDK Parity / 🏷️ Parity Decision. Renaming either job later breaks the protection rule.

Checklist

  • Followed the contribution guidelines.
  • Manual test round performed and verified.
  • Documentation provided. (Add links if there are any)
    • The workflow header and the linked specification.
  • Tests provided. (Add links if there are any)
    • Unit Tests
    • Integration Tests
  • Breaking changes. (Fill if applicable)
    • Breaking changes section filled.
    • breaking change label added.
  • Cross-SDK parity. Exactly one of parity/prs-raised or parity/prs-not-needed added.
    • If parity/prs-raised, the port links are posted as a reply on the parity check's comment.

Security checks

  • Followed secure coding standards.
  • Confirmed that this PR doesn't commit any keys, passwords, tokens, usernames, or other secrets.

A capability that ships here usually has to ship in the other ThunderID SDKs
too, and until now nothing at review time asked whether it did. The SDK
development specification states that the decision is made on every pull
request; this wires that up.

Every pull request must carry exactly one of parity/prs-raised or
parity/prs-not-needed. The check stays red until it does, and a label is the
only thing that clears it, so a change is never waved through on the strength
of the files it happened to touch. Applying the label re-runs the check, so it
goes green without a push.

The logic lives in thunder-id/.github and is shared by all four SDK
repositories, which cannot drift as a result. This file owns only the triggers,
which a reusable workflow cannot declare for its caller.

Signed-off-by: Brion <info@brionmario.com>
@coderabbitai

coderabbitai Bot commented Sep 15, 2026

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: 75708fa5-2d8e-49a2-a723-e99096dcbce5


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant