Repository navigation
Fix font descent caching across device resolutions - #6931
Open
NaumanRafay wants to merge 3 commits into
Open
NaumanRafay wants to merge 3 commits into
NaumanRafay wants to merge 3 commits into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6929.
Drawing a plot at 72 DPI could affect the text layout of a later 300-DPI export in the same R session. The font descent cache reused the low-resolution measurement because its key did not include the device resolution.
This change adds the horizontal and vertical device resolution to the cache key. It also adds a visual regression test that compares a 300-DPI export after a 72-DPI preview with a 300-DPI export from a clean cache, and a user-facing NEWS entry.
Testing
R CMD checkcould not complete the map examples becausesfwas unavailable in the local test environment.AI assistance
I used OpenAI Codex to assist in fixing the bug.