Repository navigation
It would be useful if the retry function returned the timout number #73
Description
Activity
For anyone interested, I found a way to do this. The retrier stores an array of intervals in its context that you can use to know the ms of the following attempt.
To achieve something similar to what @zkochan is tried you could have something like
const operation = retry.operation() operation.attempt(function (currentAttempt) { const nextTick = Math.ceil(this._timeouts[0] / 1000) console.log(`Will retry in ${nextTick} seconds`) })For now, I forked the repository and added the features that I needed: https://github.com/zoli-forks/node-retry
Why not PR your desired changes? I'd approve them.
👍 for this. This would most conveniently be provided along with
currentAttemptto the callback function inoperation.attempt(fn). Yeah you can calculate it with the formula or with theretry.timeoutsfunction, but it would be a good convenience to the user to just provide it. It feels like it belongs in that same spot, as users might want to log progress likeRetry #4, trying again in 20 seconds.Presumably the library already has that value ready to go and can just pass it to the function.
Reacted by Christian GencoAdded in the maintained fork
@bybrave/retry2:operation.getTimeout()returns the delay in milliseconds before the next scheduled attempt (ornullbefore the first retry), without changing the boolean contract ofretry():if (op.retry(err)) { console.warn(`request failed, retrying in ${op.getTimeout()}ms`); return; }
Handy for exactly the pnpm-style "will retry in N seconds" logging.
npm i @bybrave/retry2.
I am working on improved logging in pnpm. When a request fails, I want to print something like:
I can calculate how many retries are left but I can't know how long the retry will wait. So it would be great if the retry function would return
timeoutinstead oftruehere:node-retry/lib/retry_operation.js
Line 92 in c402d77