Tighten MCP tool schema conventions - #229
Merged
Merged
Conversation
aprimakina
approved these changes
Sep 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cleans up how our MCP tool schemas describe their fields, and documents the conventions in CLAUDE.md. Note that some of these issues were originally noticed when reviewing #228
service_listandservice_get, which had example values baked into their struct tags.OpenWorldHintis now false on every tool. Our tools only ever touch the Tiger Cloud API and the user's own services, so none of them operate on an open world. Eleven tools had it set to true.service_listandservice_gethad a Schema method that was never called, so the type enum it declared never reached clients. Those methods are now wired into the tools' output schemas.