Repository navigation
Assert nbytes <= 8 in sign_extend - #862
Merged
Merged
Conversation
GlenDC
approved these changes
Nov 9, 2026
Member
|
@princejain756 can you rebase your branch onto |
Add a debug_assert!(nbytes <= 8) check in sign_extend so out-of-range byte counts fail immediately in debug builds instead of underflowing 8 - nbytes, while keeping the nbytes == 0 branch intact.
princejain756
force-pushed
the
fix-sign-extend-assert
branch
from
November 9, 2026 21:10
ea33f37 to
bad9986
Compare
Contributor
Author
|
Thanks for the review @GlenDC! Just rebased the branch onto the latest |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #832
sign_extendcomputes(8 - nbytes) * 8, which underflows whennbytes > 8. All callers (get_int,get_int_le,try_get_int,try_get_int_le) already boundnbytesto at most 8 viaget_uint/try_get_uint, whilenbytes == 0is handled by the existing early return.This change adds
debug_assert!(nbytes <= 8, "nbytes must be in [0, 8]")insign_extendalong with unit tests coveringnbytes == 0andnbytes > 8in debug builds.