Repository navigation
Conversation
gronxb
requested review from
heecheolman,
intmain,
jingjing2222,
l2hyunwoo,
leegeunhyeok and
raon0211
as code owners
November 4, 2026 05:44
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🦋 Changeset detectedLatest commit: 9b9b6d7 The changes in this PR will be included in the next version bump. This PR includes changesets to release 32 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@granite-js/deployment-manager
@granite-js/forge-cli
@granite-js/pulumi-aws
babel-preset-granite
@granite-js/blur-view
@granite-js/brownfield-module
@granite-js/cli
@granite-js/config
@granite-js/cookies
create-granite-app
@granite-js/screen
@granite-js/image
@granite-js/jest
@granite-js/lottie
@granite-js/micro-frontend
@granite-js/mpack
@granite-js/native
@granite-js/naver-map
@granite-js/plugin-core
@granite-js/plugin-env
@granite-js/plugin-hermes
@granite-js/plugin-micro-frontend
@granite-js/plugin-router
@granite-js/plugin-rozenite
@granite-js/plugin-sentry
@granite-js/react-native
@granite-js/rollipop
@granite-js/router
@granite-js/style-utils
@granite-js/utils
@granite-js/video
@granite-js/vitest
commit: |
gronxb
marked this pull request as draft
November 4, 2026 11:10
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Extract
@granite-js/routeras a standalone package and make@granite-js/react-nativedepend on it. App registration only mounts the app with initial props and visibility lifecycle; the app renders Router below its providers so hook-derived screen defaults flow through normal React props.@granite-js/native, React, and React Native peers supply the native implementations.isActive, entry URLs, andonRootBack.defaultScreenOptionsreceivesroute,navigation,theme,routeIndex, andonBack. Updating options preserves the mounted stack. The singular spelling remains a deprecated Router alias.@granite-js/router; legacy@granite-js/react-nativemodule augmentation remains supported.For registered apps, import the host-aware Router adapter from
@granite-js/react-nativeor@granite-js/react-native/routerand register withGranite.registerApp(App, { appName }).Migration
Breaking change / major changeset: registration no longer accepts route context, router options, initial URL resolution, or gesture callbacks and no longer injects Navigator children. Render Router explicitly and supply those settings to it. Call hooks in the parent component, not inside the options callback. Supply
onRootBackwhen the host view should close.Add
@granite-js/routeras a direct dependency when importing it or using newly generated route declarations. React Navigation remains the underlying engine.Validation
@granite-js/react-nativepresent andNODE_PATHempty. Both standalone route definitions and actual plugin-generated declarations typecheck.Remaining imperative options
The only production
navigation.setOptionscall in this repository remains in the iOS StatusBar implementation (statusBarStyle,statusBarHidden). Router references are a compatibility test and back-button documentation examples. This extraction does not remove those existing APIs.