Repository navigation
Wire 60db provider into the CLI (accept --provider 60db, fix cost table, validate SIXTYDB_API_KEY) - #47
Open
nickstrooo-bot wants to merge 2 commits into
Open
Wire 60db provider into the CLI (accept --provider 60db, fix cost table, validate SIXTYDB_API_KEY)#47nickstrooo-bot wants to merge 2 commits into
nickstrooo-bot wants to merge 2 commits into
Conversation
PR tsensei#46 adds the 60db LLM/TTS providers, but as merged they are not usable end to end: - --provider 60db and --tts-provider 60db[-stream|-ws] are rejected by commander's .choices() in src/cli/args.ts - pnpm typecheck fails: ttsPerChar lacks the three new TTSProviderKey members - validate-env.ts has no SIXTYDB_API_KEY requirement, so a missing key dies as an unhandled error instead of the standard listing This wires all three up, using 60db's published pay-as-you-go rates (TTS $0.02/1K chars, chat $0.50/1M tokens, 60db.ai/pricing), and adds 20 tests across args, validate-env, cost-estimator, and factory.
|
Strix is installed on this repository, but we couldn't run this PR security review because this workspace's trial has ended. Add a card to resume code reviews here. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #46: it adds the 60db LLM/TTS providers, but as merged they aren't usable end to end.
Note: this branch is stacked on #46 (one commit,
9e3ff84). If #46 is merged first, this PR's diff shrinks to just the wiring commit below.What was broken
--provider 60dband--tts-provider 60db[-stream|-ws]are rejected by commander's.choices()insrc/cli/args.ts, so the README example (openreels "the dawn of stoicism" --provider 60db --tts-provider 60db) fails at arg parsing.pnpm typecheckfails:ttsPerCharinsrc/cli/cost-estimator.tsisRecord<TTSProviderKey, number>and lacks the three new keys.validate-env.tshad noSIXTYDB_API_KEYrequirement, so a missing key died as an unhandled error instead of the standard missing-key listing.What this changes
src/cli/args.ts: add"60db"to--providerchoices; add"60db","60db-stream","60db-ws"to--tts-providerchoices.src/cli/cost-estimator.ts: add 60db toLLM_PRICINGand the three TTS keys tottsPerChar, using 60db's published pay-as-you-go rates (TTS $0.02/1K chars, chat $0.50/1M tokens in+out — 60db.ai/pricing).src/cli/validate-env.ts: requireSIXTYDB_API_KEYwhen the LLM provider is60dbor the TTS provider is any 60db surface.args.test.ts— runtimeparseArgsfor all four flags;validate-env.test.ts— missing key exits 1 namingSIXTYDB_API_KEY, present key passes, not required when 60db isn't used;cost-estimator.test.ts— 60db LLM/TTS rates;factory.test.ts— mocked 60db LLM/TTS/cloud-aligner wiring.Verification
pnpm typecheck— clean (was failing before this change).pnpm test— full suite 443/443 pass.pnpm lint(biome check .) — repo-wide counts identical tomain(188 errors / 305 warnings / 285 infos, all pre-existing); this change adds no new diagnostics.A note on who we are: we're a small crew that picks up stalled open-source work and finishes it — happy to iterate on this if you'd like anything changed. Best way to reach us is right here on GitHub (reply in this PR, or open an issue on our fork, nickstrooo-bot/OpenReels).