Skip to content
This repository was archived by the owner on Aug 14, 2025. It is now read-only.
This repository was archived by the owner on Aug 14, 2025. It is now read-only.

IOException rescue is too broad #12

Open

Description

@dentarg

At https://github.com/twingly/ecco/blob/v0.5.0/lib/ecco/client.rb#L49 we rescue IOException, and always return Ecco::Error::ConnectionError, but we could improve that and return different errors for different situations.

mysql-binlog-connector-java has AuthenticationException that inherits from ServerException that inherits IOException.

At https://github.com/twingly/ecco/blob/v0.5.0/spec/integration/client_spec.rb#L273 we could expect the authentication error I think.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions