Repository navigation
Include original exception in new exception in on_communication_failure #13
Description
Activity
Not sure how we should solve this. There is no
Exception#cause=method. We could implement our own on the error classes, but would be nice if there was a way to avoid that :)Some related comments: https://bugs.ruby-lang.org/issues/8257#note-32
Ah yes, we could tweak the error message instead possibly. Like:
message = "#{exception.get_name}: #{exception.get_message)" error = Ecco::Error::CommunicationError.new(message)
I think Sequel does something like this when wrapping, say, PostgreSQL errors.
We could implement our own on the error classes
I was thinking that.
They do both :) (Message and wrap).
True, maybe we should just extract all info there is to our own Ruby exception
The API doesn't look that big: https://docs.oracle.com/javase/7/docs/api/java/lang/Throwable.html
Interesting issue about Java and Ruby exceptions: jruby/jruby#4781
we could do two passes:
- just include the class name (as suggested in Include original exception in new exception in on_communication_failure #13 (comment)) (this would close this issue)
- error super object with stuff like orignal stacktrace and what not (new issue)
Reacted by Mattias Roback
At https://github.com/twingly/ecco/blob/v0.5.0/lib/ecco/lifecycle_failure_listener.rb#L9-L12 we get an exception from Java, and create a new Ruby exception which we return to the user with the message from the old exception.
Often the message is
nil, so it would be useful to also include the original exception, to help the user understand what's going on.Like Ruby does since 2.1 with Exception Causes.