Skip to content
This repository was archived by the owner on Aug 14, 2025. It is now read-only.
This repository was archived by the owner on Aug 14, 2025. It is now read-only.

Convert rows to Ruby class #26

Open

Description

@jage

Currently the rows are Java's AbstractMap::SimpleEntry, a Ruby Array or Hash (or similar) would make it easier to integrate with Ecco.

Activity

  1. walro commented on Oct 26, 2020

    @walro
    Contributor

    Not sure I understand, a Row is already a (J)Ruby object:

    row_event = Ecco::RowEvent.new

  2. walro commented on Oct 26, 2020

    @walro
    Contributor

    Ah, title was a bit misleading, it should probably say just "rows", not "row events". The problem is

    row_event.rows = data.rows

  3. changed the title [-]Convert row events to Ruby class[/-] [+]Convert rows to Ruby class[/+] on Oct 26, 2020
  4. added 2 commits that reference this issue on Oct 29, 2020
  5. linked a pull request that will close this issueConvert rows from Java to Ruby class #57on Nov 3, 2020
  6. added a commit that references this issue on Mar 10, 2021
  7. Chrizpy commented on Jul 8, 2021

    @Chrizpy
    Contributor

    Started a bit on this here #57
    Closing the PR for now though due to priorities.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions