Skip to content

ICU-23473 cldr building improvements for 49 - #4100

Merged
srl295 merged 1 commit into
unicode-org:mainfrom
srl295:srl295/icu-23473/cldr-49-patch
Oct 1, 2026
Merged

ICU-23473 cldr building improvements for 49#4100
srl295 merged 1 commit into
unicode-org:mainfrom
srl295:srl295/icu-23473/cldr-49-patch

Conversation

@srl295

@srl295 srl295 commented Jul 25, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

ICU-23473

  • document tools/cldr/build.py as the recommended build tool
  • add options to support several phases of the build process
  • other build docs improvements

Checklist

  • Required: Issue filed: ICU-23473
  • Required: The PR title must be prefixed with a JIRA Issue number. Example: "ICU-NNNNN Fix xyz"
  • Required: Each commit message must be prefixed with a JIRA Issue number. Example: "ICU-NNNNN Fix xyz"
  • Issue accepted (done by Technical Committee after discussion)
  • Approver: Feel free to merge on my behalf

@srl295 srl295 closed this Jul 25, 2026
@srl295 srl295 reopened this Jul 25, 2026
@srl295 srl295 changed the title srl295/icu 23473/cldr 49 patch ICU-23473 cldr building improvements for 49 Jul 25, 2026
@srl295
srl295 requested review from DraganBesevic and mihnita July 25, 2026 17:34
@srl295
srl295 marked this pull request as draft July 25, 2026 17:35
mihnita
mihnita requested changes Jul 26, 2026
View reviewed changes

@mihnita mihnita left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed.
Thank you,
M.

Comment thread tools/cldr/build.py Outdated
Comment thread tools/cldr/build.py Outdated
Comment thread tools/cldr/build.py
@srl295

srl295 commented Jul 26, 2026

Copy link
Copy Markdown
Member Author

Reviewed.
Thank you,
M.

Thanks!

@srl295

srl295 commented Jul 26, 2026

Copy link
Copy Markdown
Member Author

Reviewed. Thank you, M.

thanks, it's still not working yet

@srl295

srl295 commented Aug 5, 2026

Copy link
Copy Markdown
Member Author

This also fixes the current error message so it gives you some hint where the alias value comes from (the "Processing" line)

Exception in thread "main" java.lang.IllegalArgumentException: Processing calendar/ethiopic-amete-alem
…
Caused by: java.lang.IllegalArgumentException: no such alias value: /LOCALE/calendar/ethiopic

mihnita
mihnita previously approved these changes Sep 29, 2026
View reviewed changes

@mihnita mihnita left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!
M

Comment thread tools/cldr/build.py Outdated
@srl295
srl295 force-pushed the srl295/icu-23473/cldr-49-patch branch from 884d32b to 3e5a582 Compare September 30, 2026 02:08
@jira-pull-request-webhook

jira-pull-request-webhook Bot commented Sep 30, 2026

Copy link
Copy Markdown

Notice: the branch changed across the force-push!

  • docs/processes/cldr-icu.md is now changed in the branch
  • tools/cldr/build.py is different
  • tools/cldr/cldr-to-icu/src/main/java/org/unicode/icu/tool/cldrtoicu/LdmlConverter.java is no longer changed in the branch
  • tools/cldr/cldr-to-icu/src/main/java/org/unicode/icu/tool/cldrtoicu/mapper/AbstractPathValueMapper.java is no longer changed in the branch
  • tools/cldr/cldr-to-icu/src/main/java/org/unicode/icu/tool/cldrtoicu/mapper/LocaleMapper.java is no longer changed in the branch
  • tools/cldr/cldr-to-icu/src/main/resources/ldml2icu_locale.txt is no longer changed in the branch
  • tools/cldr/README.md is now changed in the branch

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

@srl295
srl295 marked this pull request as ready for review September 30, 2026 02:11
@srl295
srl295 requested a review from mihnita September 30, 2026 02:12
@srl295

srl295 commented Sep 30, 2026

Copy link
Copy Markdown
Member Author

@mihnita thanks. Rebased and cleaned up.

@srl295 srl295 mentioned this pull request Sep 30, 2026
Draft
7 tasks
@srl295
srl295 force-pushed the srl295/icu-23473/cldr-49-patch branch from 3e5a582 to 7313704 Compare September 30, 2026 11:37
@jira-pull-request-webhook

jira-pull-request-webhook Bot commented Sep 30, 2026

Copy link
Copy Markdown

Notice: the branch changed across the force-push!

  • tools/cldr/build.py is different
  • tools/cldr/cldr-to-icu/README.md is no longer changed in the branch

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

@srl295
ICU-23473 improve tools/cldr/build.py
91ac5ac 
- document as the recommended build tool
- add options to support several phases of the build process
- other build docs improvements
@srl295
srl295 force-pushed the srl295/icu-23473/cldr-49-patch branch from 7313704 to 91ac5ac Compare September 30, 2026 11:57
@jira-pull-request-webhook

jira-pull-request-webhook Bot commented Sep 30, 2026

Copy link
Copy Markdown

Notice: the branch changed across the force-push!

  • tools/cldr/build.py is different

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

mihnita
mihnita approved these changes Oct 1, 2026
View reviewed changes

@mihnita mihnita left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@srl295
srl295 merged commit 0d0fa6b into unicode-org:main Oct 1, 2026
9 checks passed
@srl295
srl295 deleted the srl295/icu-23473/cldr-49-patch branch October 1, 2026 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mihnita mihnita mihnita approved these changes
@DraganBesevic DraganBesevic Awaiting requested review from DraganBesevic

Assignees

@mihnita mihnita

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@srl295 @mihnita