Skip to content

ICU-23198 Add comment explaining why the code is correct as is - #4202

Merged
mihnita merged 1 commit into
unicode-org:mainfrom
mihnita:mihai_23198
Sep 17, 2026
Merged

mihnita merged 1 commit into
unicode-org:mainfrom
mihnita:mihai_23198

Conversation

@mihnita

@mihnita mihnita commented Sep 17, 2026

Copy link
Copy Markdown
Contributor

This change is extracted from PR #4070 by FrankYFTang, so that we can close the ticket for ICU 79.1 even without that big PR landing.

Checklist

  • Required: Issue filed: ICU-23198
  • Required: The PR title must be prefixed with a JIRA Issue number. Example: "ICU-NNNNN Fix xyz"
  • Required: Each commit message must be prefixed with a JIRA Issue number. Example: "ICU-NNNNN Fix xyz"
  • Issue accepted (done by Technical Committee after discussion)
  • Tests included, if applicable
  • API docs and/or User Guide docs changed or added, if applicable
  • Approver: Feel free to merge on my behalf

This change is extracted from PR #4070 by FrankYFTang, so that we can close
the ticket for ICU 79.1 even without that big PR landing.
@jira-pull-request-webhook

Copy link
Copy Markdown

Notice: the branch changed across the force-push!

  • tools/scripts/scrub_issues/new_scrub_results.txt is no longer changed in the branch

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

@richgillam richgillam left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mihnita

mihnita commented Sep 17, 2026

Copy link
Copy Markdown
Contributor Author

Thank you!

@mihnita
mihnita merged commit f11db9e into unicode-org:main Sep 17, 2026
98 checks passed
@mihnita
mihnita deleted the mihai_23198 branch September 17, 2026 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants