Repository navigation
fix: cap google provider below 8.0.0 - #4
Merged
Merged
Conversation
google 8.0.0 makes secret_data_wo_version mandatory alongside secret_data_wo, which breaks the apply of the Secret Manager secret version in this module. Constrain google to < 8.0.0, and add matching major-version bounds for random and time, so that a new provider major cannot reach users before it is tested.
tommouwes
approved these changes
Sep 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
googleprovider 8.0.0 makessecret_data_wo_versionmandatory alongsidesecret_data_wo. Thegoogle_secret_manager_secret_versionresource in this module sets onlysecret_data_wo, so an apply fails for any user who picks up the new provider major.The
required_providersblock had no upper bounds, so Terraform selected 8.0.0 on a freshinit.Change
googleto>= 6.23.0, < 8.0.0.random(< 4.0.0) andtime(< 1.0.0), so that a new provider major cannot reach users before it is tested.versions.tfthat records why the bounds exist.terraform-docsblock in the module README.Verification
terraform fmt -check -recursive modules/— passterraform init -backend=falseandterraform validateonmodules/gcp-audit-logs— passterraform-docsoutput matches the committed READMEScope
Module only. The example keeps its lower bounds; Terraform intersects them with the module constraint, so the example still resolves to a supported provider.