Skip to content

fix: cap google provider below 8.0.0 - #4

Merged
EladBrosh merged 1 commit into
mainfrom
fix/cap-google-provider-major
Sep 8, 2026
Merged

EladBrosh merged 1 commit into
mainfrom
fix/cap-google-provider-major

Conversation

@EladBrosh

Copy link
Copy Markdown
Contributor

Problem

google provider 8.0.0 makes secret_data_wo_version mandatory alongside secret_data_wo. The google_secret_manager_secret_version resource in this module sets only secret_data_wo, so an apply fails for any user who picks up the new provider major.

The required_providers block had no upper bounds, so Terraform selected 8.0.0 on a fresh init.

Change

  • Constrain google to >= 6.23.0, < 8.0.0.
  • Add matching major-version bounds for random (< 4.0.0) and time (< 1.0.0), so that a new provider major cannot reach users before it is tested.
  • Add a comment in versions.tf that records why the bounds exist.
  • Regenerate the terraform-docs block in the module README.

Verification

  • terraform fmt -check -recursive modules/ — pass
  • terraform init -backend=false and terraform validate on modules/gcp-audit-logs — pass
  • terraform-docs output matches the committed README

Scope

Module only. The example keeps its lower bounds; Terraform intersects them with the module constraint, so the example still resolves to a supported provider.

google 8.0.0 makes secret_data_wo_version mandatory alongside
secret_data_wo, which breaks the apply of the Secret Manager secret
version in this module. Constrain google to < 8.0.0, and add matching
major-version bounds for random and time, so that a new provider major
cannot reach users before it is tested.
@EladBrosh
EladBrosh merged commit 68302f9 into main Sep 8, 2026
12 checks passed
@EladBrosh
EladBrosh deleted the fix/cap-google-provider-major branch September 8, 2026 11:37
@upwindsecurity upwindsecurity deleted a comment from upwind-code-us Bot Oct 14, 2026
@upwindsecurity upwindsecurity deleted a comment from upwind-code-us Bot Oct 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants