Skip to content

ci: add timeouts and fail-fast guards to the workflows #549

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JalonSolov merged 3 commits into from
Oct 19, 2026
Merged

ci: add timeouts and fail-fast guards to the workflows #549

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
096ad32
ci: add timeouts and fail-fast guards to the workflows
metif12 Oct 15, 2026
801e128
ci: fix guard shape, reusable timeouts, and chain completeness
metif12 Oct 15, 2026
9196513
ci: bound every step, and give Windows the repo the tests need
metif12 Oct 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,14 +38,22 @@ jobs:
${{ matrix.os == 'ubuntu' && (vars.VLS_RUNNER_LINUX || 'ubuntu-latest') ||
matrix.os == 'macos' && (vars.VLS_RUNNER_MACOS || 'macos-latest') ||
(vars.VLS_RUNNER_WINDOWS || 'windows-latest') }}
# A last-resort ceiling, not the fail-fast mechanism. Every step below
# carries its own `timeout-minutes`, so a step that wedges fails at its own
# budget instead of letting the job spend the rest of this one on it. The
# budgets sit well above what a healthy run needs and sum to more than this
# value on purpose: a `-prod` master push runs every one of them, and this
# should never be the thing that fires first.
timeout-minutes: 60

steps:
- name: Checkout V
timeout-minutes: 10
uses: actions/checkout@v5
with:
repository: vlang/v
- name: Checkout VLS
timeout-minutes: 10
uses: actions/checkout@v5
with:
path: vls
Expand All @@ -54,22 +62,27 @@ jobs:
# nothing here is pinned and every run tests against the latest compiler.
- name: Build V
if: matrix.os != 'windows'
timeout-minutes: 20
run: make latest_tcc && make -j4 && ./v symlink
- name: Build V (Windows)
if: matrix.os == 'windows'
timeout-minutes: 20
run: ./makev.bat latest_tcc && ./makev.bat && ./v symlink

# Hover, completion, signature help, and go to definition run through
# `-line-info`, which only the compatibility compiler implements now that
# V3 is the default backend. `makev.bat` already builds it on Windows.
- name: Build the V compatibility compiler
if: matrix.os != 'windows'
timeout-minutes: 15
run: make v1

- name: Check formatting
timeout-minutes: 5
run: v fmt -verify vls/

- name: Run all tests, including the vlang/v workspace tests
timeout-minutes: 30
env:
VLS_VLANG_V_REPO: ${{ github.workspace }}
V_MACOS_V3_NO_FALLBACK: ${{ matrix.os == 'windows' && '0' || '1' }}
Expand All @@ -87,6 +100,7 @@ jobs:
if: matrix.os == 'windows' && github.event_name != 'pull_request'
timeout-minutes: 30
env:
VLS_VLANG_V_REPO: ${{ github.workspace }}
V_MACOS_V3_NO_FALLBACK: "0"
run: v -no-memory-limit -nocache -prod test vls/

Expand All @@ -103,10 +117,12 @@ jobs:
# unnoticed until someone built with -new-compiler by hand. Both paths are
# cheap to compile, so cover all three platforms.
- name: Compile project with V3
timeout-minutes: 15
env:
V_MACOS_V3_NO_FALLBACK: "1"
run: v -no-memory-limit -nocache -new-compiler vls/

- name: Compile project
if: matrix.os == 'windows'
timeout-minutes: 15
run: v -nocache vls/
Loading