Repository navigation
Conversation
fspy benchmarklinuxmacoswindows |
wan9chi
force-pushed
the
feat/cache-rebuildable-folders
branch
from
October 30, 2026 03:19
91b15b8 to
b25c11e
Compare
wan9chi
force-pushed
the
feat/cache-rebuildable-folders
branch
from
October 30, 2026 04:07
b25c11e to
4dff101
Compare
wan9chi
force-pushed
the
feat/cache-rebuildable-folders
branch
from
October 30, 2026 06:31
4dff101 to
9f74d41
Compare
Two cases for a task that reads a folder holding only its own outputs. In `stat_own_output_folder`, the task makes `out`, writes `out/a.txt` and stats `out`, through `vtt fs`. In `typescript_out_dir`, TypeScript 7's `tsc` compiles `src` into `dist`: it stats `dist` and lists the package root, where the hard-coded `dist` skip hides the folder. Today removing the output folder, as on a clean checkout, is a cache miss naming the folder, although the cached outputs hold everything in it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A task that stats or lists a folder holding only its own outputs, like TypeScript 7's `tsc` statting `dist`, pinned that folder as an input, so removing it, as on a clean checkout, was a cache miss although a hit restores every file in it. After the run, `Rebuildable` now climbs from the written paths through their parent folders inside the workspace and lists each folder in the real file system, deepest first. A folder is rebuildable when it isn't empty, every file or symlink in it is a path the task wrote, and every folder in it is rebuildable; climbing stops at the first folder that isn't. A folder that is gone by then, like the `dist/.prerender` that Astro writes to and deletes, plays no part, like a written file that is gone: its parent is decided by the entries it holds. A rebuildable folder the task read gets no inferred-input fingerprint. The archive is unchanged: the written files in such a folder are archived already, and restoring them recreates it. An empty folder isn't rebuildable yet, and a listing of the folder's parent still names it. `vt_path` gets `RelativePath::parent` for the climb. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
wan9chi
force-pushed
the
feat/cache-rebuildable-folders
branch
from
October 30, 2026 07:08
9f74d41 to
9ad3c84
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
A task that stats or lists a folder holding only its own outputs pins that folder as an input. TypeScript 7's
tsc, for example, statsdistwhile emitting into it. Removing the folder, as on every clean checkout in CI, is then a miss, although a hit restores every file in it.Changes
After the run, vt climbs from the written paths through their parent folders and lists each folder once, deepest first. A folder is rebuildable when it isn't empty, every file or symlink in it was written by the task, and every folder in it is rebuildable. A folder that's gone by then, like Astro's
dist/.prerender, plays no part. A rebuildable folder gets no inferred-input fingerprint; restoring its files recreates it.vt_pathgetsRelativePath::parent.E2E cases:
stat_own_output_folder(synthetic) andtypescript_out_dir(TypeScript 7 emitting todist). Removing the output folder misses today and hits with the folder restored after.Part of a stack that lets automatic tracking cache tasks which read their own outputs and list the folders holding them, so they also hit on a clean checkout.
🤖 Generated with Claude Code
Note
Medium Risk
Changes post-run input fingerprinting and cache-hit rules for auto-tracked directory reads; incorrect rebuildable classification could hide real input changes or allow stale hits.
Overview
Tasks that stat or list an output directory (e.g.
tscondist) no longer treat that folder as a tracked input when every entry in it is something the task wrote. Post-run fingerprinting skips those “rebuildable” directories, so a clean checkout with the folder gone can still cache hit and restore archived outputs, recreating the tree.Rebuildablenow walks parent paths from fspy’s unfiltered writes after the run, classifies directories whose live listing contains only written files/symlinks and already-known rebuildable subfolders (ignoring.DS_Store, ignoring dirs removed before classification), and exposesis_rebuildable_folder.PostRunFingerprint::createfilters those paths out alongside prerun globs.RelativePath::parentsupports the climb.Docs/changelog and e2e fixtures cover a synthetic
stat outcase and TypeScript emitting todist(typescript fixture markedignorein snapshots.toml).Reviewed by Cursor Bugbot for commit 9ad3c84. Bugbot is set up for automated code reviews on this repo. Configure here.