Skip to content

fix: let a mouse or pen jog a joint slider a pixel off the joint - #655

Merged
temmuz merged 1 commit into
revampfrom
fix/joint-slider-dead-zone
Nov 19, 2026
Merged

temmuz merged 1 commit into
revampfrom
fix/joint-slider-dead-zone

Conversation

@temmuz

@temmuz temmuz commented Nov 19, 2026

Copy link
Copy Markdown
Contributor

Lets a mouse or pen jog a joint with the JoggingJointSlider from a press a pixel off the joint, so that small jogs work on joints with a wide range.

The dead zone was 4 px for every pointer. RobotPad's UR5e joints span ±360° on a 272 px track (2.6° per px), so a press closer than 10.6° to the joint did nothing: the slider showed the goal, but the press jogged nothing.

  • Mouse and pen: a goal 1 px or more off the joint jogs it. These pointers keep still, so the track's pixels are the only limit.
  • Finger: keeps the 4 px. A finger trembles by a few pixels, and the joint must not follow that back and forth. A finger also lands less precisely than 4 px, so a smaller dead zone would not make it finer.
  • Unknown pointer type (only in tests and scripted events): 4 px, to be safe.
  • No public API change.

Stacked on #654, which changes the same lines of the slider. Once #654 is merged, this goes on top of revamp.

Checked

  • Unit tests: a mouse or pen press 2 px off jogs, a press on the joint's own pixel does not, and a finger's press and jitter near the joint do not. Breaking each rule on purpose fails a test.

  • Playground on a NOVA instance (mock UR5e, ±360°):

    Track Press Result
    926 px finger, 3 px off no jog
    926 px mouse, 3 px off jogged 2.3° to the goal, 0.1° past
    302 px (2.4° per px) mouse, 2 px below jogged −4.9°, 0.15° past the goal
    302 px mouse, 2 px above jogged +4.8°, 0.01° short of the goal

Base automatically changed from refactor/shared-hold-safety to revamp November 19, 2026 14:16
The joint slider's dead zone was 4 px for every pointer. On a joint with a
wide range that is a lot: RobotPad's UR5e joints span ±360° on a 272 px
track, so a press closer than 10.6° to the joint did nothing.

The dead zone keeps a pointer's jitter from jogging the joint. A mouse or
pen keeps still, so its dead zone is now 1 px. A finger keeps the 4 px: it
trembles by a few pixels, and lands less precisely than that anyway.
@temmuz
temmuz force-pushed the fix/joint-slider-dead-zone branch from 6f2e6a2 to afdb05c Compare November 19, 2026 14:17
@temmuz
temmuz merged commit d758c48 into revamp Nov 19, 2026
3 checks passed
@temmuz
temmuz deleted the fix/joint-slider-dead-zone branch November 19, 2026 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant