Repository navigation
feat: add TrajectoryExecutionStore, RobotPad's Move to engine: plan, load, start and pause a move to a pose - #660
Merged
Conversation
temmuz
force-pushed
the
feat/jogging-store-from-robotpad
branch
from
November 20, 2026 11:16
1c252a3 to
f3f59a7
Compare
…load, start and pause a move to a pose
RobotPad keeps its Move to engine (src/util/TrajectoryExecutionStore.ts)
on its own. This brings it into the library, without the app around it,
so that RobotPad and other apps use one engine:
- new TrajectoryExecutionStore({ joggingStore, isLocked?,
ensureMovementOwnership?, logger? }) uses the jogging store's jogger:
its NOVA connection, cell, motion group, motion stream and planner
model, and the store's TCP and velocities.
- planTrajectory(target) plans a PTP move to a cartesian pose (in world,
or in a coordinate system, transformed into world) or to joints, and
loads it on an execution websocket, so that start() can run it at once.
A planner rejection is a result ({ ok: false, errorFeedbackName }), not
an exception; planErrorTranslationKey turns it into a message (en, de).
- start(), pause() (until the robot stands still), stopAndReset(),
reset(); trajectoryState: idle, planning, planned, moving, stopping;
reset at the end of the trajectory; lastError.
- By default the move takes the robot over from jogging (it deactivates
the jogging store and switches the jogger to its trajectory mode), as
RobotPad does; an app can pass its own ensureMovementOwnership.
Differences from RobotPad's copy: a planner that cannot be reached no
longer leaves the store in "planning"; state changes after an await run
in MobX actions; an initialization that NOVA answers with an error
message is a refusal, as for JoggerConnection's steps, and its message
goes to lastError.
temmuz
force-pushed
the
feat/move-to-engine-from-robotpad
branch
from
November 20, 2026 11:17
d411021 to
62e6fd1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The fourth PR that brings RobotPad's newer logic into the library, so that RobotPad can use it and delete its copies (#657
MotionStreamConnection, #658JoggerConnection, #659JoggingStore; this one is stacked on #659). This one adds RobotPad's Move to engine,TrajectoryExecutionStore, without the app around it.The API
new TrajectoryExecutionStore({ joggingStore, isLocked?, ensureMovementOwnership?, logger? })uses the jogging store's jogger: its NOVA connection, cell, motion group, motion stream and planner model, and the store's TCP and velocities.isLockeddefaults to never locked.planTrajectory(target): a PTP move to a cartesian pose ({ type: "cartesian", pose, coordinateSystemId? }, in world or in a coordinate system that is transformed into world with thePoseTransformerof feat: take RobotPad's JoggingStore into the library: "Move relative to", jog errors, velocity defaults #659) or to joints ({ type: "joint", joints }). It loads the trajectory on an execution websocket, so thatstart()runs it at once. A planner rejection is a result ({ ok: false, errorFeedbackName }), not an exception;planErrorTranslationKeyturns it into a message (RobotPad's texts, en and de).start(),pause()(until the robot stands still),stopAndReset(),reset(),clearError(),dispose();trajectoryState(idle,planning,planned,moving,stopping),plannedTrajectory,lastError,executionState. It resets at the end of the trajectory.ensureMovementOwnership.Differences from RobotPad's copy
awaitrun in MobX actions (RobotPad's copy logs strict-mode warnings there).messageis a refusal, as for the steps of feat: take RobotPad's step jogging and coordinate-system jogging into JoggerConnection #658, and the message goes tolastError(RobotPad's copy counted it as accepted).JoggerConnectiondoes, instead of comparing NATS joint values; notcpIdin the target (RobotPad plans with the selected TCP too).The playground's Move to demo (#656) switches to this engine in a follow-up, once #656 is in.
Public API
Additions only:
TrajectoryExecutionStore, its options,TrajectoryTarget,PlanTrajectoryResult,PlannedTrajectory,TrajectoryState,planErrorTranslationKey. API reports updated.Checked
api:check, consumer tests, and on a NOVA instancetest:e2e(2) and all 17 playground tests.Known, older than this PR
JoggerConnection's step jogs (in the library before and in RobotPad) send the controller's limits asglobalin the motion group setup; NOVA's field isglobal_limits. To check and fix on its own.