Render blog details with a native SwiftUI list by crazytonyli · Pull Request #26026 · wordpress-mobile/WordPress-iOS

crazytonyli · 2026-09-17T22:14:54Z

Note

This PR will be merged after 27.3 code freeze, to give us a bit more time to test the changes during development.

Description

This prepares the site menu for SwiftUI destinations while keeping BlogDetailsViewController as the UIKit entry point.

Replace the table view with a native List, including sidebar selection, badges, and section styling.
Move the site header and pull-to-refresh into the list. The existing UIKit header and cards are embedded in SwiftUI.

Existing menu destinations retain UIKit routing. Native SwiftUI navigation for Comments follows in a separate PR.

Scrolling the site menu in My Site no longer reveals the navigation-bar title. Dashboard behavior is unchanged.

Testing instructions

Switch between the dashboard and site menu. Check the header, scrolling, and pull-to-refresh.
Scroll the site menu and confirm that the navigation-bar title stays hidden. On the dashboard, confirm that scrolling still reveals it.
Switch sites and open Posts, Pages, Comments, and pinned custom post types.
On iPad, check sidebar selection and detail-column navigation.
Check card sizing and row layout with large text.

dangermattic · 2026-09-17T22:15:19Z

	1 Warning
⚠️	This PR is larger than 500 lines of changes. Please consider splitting it into smaller PRs for easier and faster reviews.

Generated by 🚫 Danger

wpmobilebot · 2026-09-17T22:27:03Z

📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.

	App Name	WordPress
	Configuration	Release-Alpha
	Build Number	`34649`
	Version	`PR #26026`
	Bundle ID	`org.wordpress.alpha`
	Commit	`2c1ab5b`
	Installation URL	6v166gnb09qio

Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

wpmobilebot · 2026-09-17T22:27:13Z

📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.

	App Name	Jetpack
	Configuration	Release-Alpha
	Build Number	`34649`
	Version	`PR #26026`
	Bundle ID	`com.jetpack.alpha`
	Commit	`2c1ab5b`
	Installation URL	25hp3u6dcsho0

Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

crazytonyli · 2026-09-18T01:07:35Z

            return
        }
-        if scrollView.contentOffset.y >= 60 {
+        if currentSection == .dashboard && scrollView.contentOffset.y >= 60 {


This is an intentional change. When the blog details is displayed standalone on WordPress, we no longer show or hide the navigation bar depending on scrolling positions. Toggling navigation bar messes with SwiftUI list and results in very confusing list jumps. I decided to remove the toggling, instead of working around the jumps.

crazytonyli · 2026-09-18T01:08:35Z

+        } header: {
+            if let title = section.title, !title.isEmpty {
+                Text(title)
+            }


Another small UI change: the header and footer now uses the default system layout, which has slightly large spacing than the old UIKit implementation. I think that's acceptable.

wpmobilebot · 2026-10-20T06:38:50Z

Version 27.4 has now entered code-freeze, so the milestone of this PR has been updated to 27.5.

jkmassel

Requesting changes for two site-switching bugs on iPhone, plus four smaller regressions. The native list itself works well: rows, selection, the iPad sidebar and scrolling all behaved.

Must fix

The site switcher stays open after picking a site. See the comment on removeChildFromStackView.
The site header can disappear, which removes the site switcher until relaunch. See the comment in BlogDetailsView.

Should fix

The site header jumps above the Me header in Reader mode.
The create button can be hidden after a site switch.
The Jetpack install card can show the wrong plugin.
Disclosure chevrons point the wrong way in right-to-left languages.

One non-blocking note on iPad default rows is also inline.

Suggestions

All seven suggestions and the diff in the first comment were applied together, built and run in the app. The three blank header suggestions need to go in as a batch.

How this was checked

Commits: this PR at c104b70 against its merge base e9e8c90.
Setup: Jetpack Debug on an iPhone 18 Pro and an iPad Pro 13 (M5) simulator, iOS 27.0, with a WordPress.com site and local self-hosted sites.
Not run: a physical device, the WordPress app, the Reader app itself, and the unit tests with the suggestions applied.

Checked, no problem found

Index-based sections: no crash in 4,000 cycles of shrinking the sections, including during scrolling. Hiding a card left the rows correct.
Nav bar after a site change: it hides correctly on the site menu.
Readable width: the list is 8 pt wider in iPhone landscape, which looks fine.
iPad sidebar: selection and detail navigation work for Stats, Posts and Comments.

jkmassel · 2026-10-30T19:21:01Z

+            if let headerViewController {
+                Section {
+                } header: {
+                    BlogDetailsHeader(controller: headerViewController)


The site header can disappear for good, and the user can no longer switch sites.

What happens: leave the site menu for a dashboard site, then come back before the metadata sync ends. The header area stays blank.

Who is affected: anyone with both a WordPress.com site and a self-hosted site, on iPhone.

What they see: no site name and no site switcher until they relaunch the app. Waiting and changing tabs did not bring it back.

Why: hideBlogDetails detaches the header, but the old BlogDetailsViewController stays alive during the sync. When the header is put back, SwiftUI sees the same controller and never re-embeds it.

Suggested fix: give the header a new .id each time it is attached. This needs the suggestions on lines 6 and 26 here and the one on headerViewController, so apply them as a batch.

Suggested change

BlogDetailsHeader(controller: headerViewController)

BlogDetailsHeader(controller: headerViewController)

.id(headerEmbedID)

Merge base This PR With the suggestion

How this was checked: it reproduced about 4 and 11 seconds after leaving the site menu, but not after 32 seconds. The merge base was fine with the same taps. Re-embedding the header in updateUIViewController was also tried, and it did not fix this.

jkmassel · 2026-10-30T19:21:01Z

+
+struct BlogDetailsView: View {
+    @ObservedObject var viewModel: BlogDetailsTableViewModel
+    var headerViewController: UIViewController?


Part of the blank header fix on line 26.

Suggested change

var headerViewController: UIViewController?

var headerViewController: UIViewController?

var headerEmbedID = UUID()

jkmassel · 2026-10-30T19:21:01Z

    public weak var presentedSiteSettingsViewController: UIViewController?

+    var headerViewController: UIViewController? {
+        didSet { hostingController?.rootView.headerViewController = headerViewController }


Part of the blank header fix in BlogDetailsView.

Suggested change

didSet { hostingController?.rootView.headerViewController = headerViewController }

didSet {

hostingController?.rootView.headerViewController = headerViewController

hostingController?.rootView.headerEmbedID = UUID()

}

jkmassel · 2026-10-30T19:21:01Z

+        if blogDetailsViewController.parent == nil {
+            if let headerViewController {
+                blogDetailsViewController.headerViewController = headerViewController
+                removeChildFromStackView(headerViewController)


The site switcher stays open after picking a site.

What happens: on a dashboard site, open the switcher and pick a self-hosted site. The site changes behind the sheet, but the sheet stays up.

Who is affected: anyone switching from a dashboard site to a site-menu site, on iPhone.

What they see: the sheet was still open after 20 seconds. Only Close clears it.

Why: this line detaches the header while it is still presenting the sheet. HomeSiteHeaderViewController then calls dismiss on a controller with no parent, and nothing happens.

Suggested fix: keep a reference to the sheet before switching. The file is outside this PR's diff, so this can't be a suggestion.

onSiteSelected: { [weak self] site in + let presented = self?.presentedViewController self?.switchToBlog(site) RecentSitesService().touch(blog: site) - self?.dismiss(animated: true) { [weak self] in + presented?.dismiss(animated: true) { [weak self] in self?.onBlogListDismiss?() }

Merge base This PR With the suggestion

How this was checked: the same taps on the merge base and with this diff both close the sheet.

jkmassel · 2026-10-30T19:21:01Z

+        blogDetailsViewController.remove()
+        if let header {
+            addChild(header)
+            stackView.insertArrangedSubview(header.view, at: 0)


After a site change in Reader mode, the site header jumps above the Me header.

What happens: every configure(for:) on the dashboard path runs showBlogDetails then hideBlogDetails. That removes the header and puts it back at the top of the stack.

Who is affected: the Reader app, after its first site change.

What they see: the header order flips, as below.

Suggested fix: put the header back directly above the dashboard.

Suggested change

stackView.insertArrangedSubview(header.view, at: 0)

let dashboardView = blogDashboardViewController?.view

let index =

stackView.arrangedSubviews.firstIndex { $0 === dashboardView } ?? stackView.arrangedSubviews.count

stackView.insertArrangedSubview(header.view, at: index)

Merge base This PR With the suggestion

How this was checked: the Reader target does not build, so this ran in the Jetpack app with isReaderAppModeEnabled forced on. The stack order was also read from a view dump: merge base and the suggestion give Me, spacer, separator, site header, dashboard. This PR gives site header first.

jkmassel · 2026-10-30T19:21:01Z

+            blogDetailsViewController.onRefresh = { [weak self] in
+                await self?.refreshSiteMenu()
+            }
+            add(blogDetailsViewController)


Switching site from outside My Site can hide the create button.

What happens: add(_:) puts the list on top of the button. The blog setter creates the button before configure(for:), so nothing moves it back up.

Who is affected: anyone on a dashboard site when showBlogDetails(for:) moves them to a site-menu site. Spotlight and share notices use that call.

What they see: no create button until they change tabs and come back.

Suggested fix: insert the list directly above the scroll view, which keeps the button on top.

Suggested change

add(blogDetailsViewController)

addChild(blogDetailsViewController)

view.insertSubview(blogDetailsViewController.view, aboveSubview: scrollView)

blogDetailsViewController.didMove(toParent: self)

Merge base This PR With the suggestion

How this was checked: showBlogDetails(for:) was called directly, not through Spotlight or a share notice. A view dump shows the list above the button on this PR and below it with the suggestion.

jkmassel · 2026-10-30T19:21:01Z

+                BlogDetailsCard(viewModel: viewModel, category: section.category)
+                    .selectionDisabled()
+                    .id(section.category)
+                    .id(viewModel.blog.objectID)


The Jetpack install card keeps showing old data after a sync.

What happens: the old table reconfigured the cell on every reload. updateUIView is now empty, and the card's .id doesn't change, so it is never rebuilt.

Who is affected: sites using individual Jetpack plugins, when the active plugin changes while the menu is open.

What they see: the wrong plugin name. In the screenshots both builds have saved Jetpack VaultPress Backup, but this PR still says Jetpack Search.

Suggested fix: rebuild the card when the plugins change.

Suggested change

.id(viewModel.blog.objectID)

.id(viewModel.blog.objectID)

.id(viewModel.blog.jetpackConnectionActivePlugins)

Merge base This PR With the suggestion

How this was checked: a local proxy changed the plugin in the site response, then a real pull to refresh picked it up. Only the install card was tested. JetpackBrandingMenuCardCell has the same empty update, and this suggestion does not cover it.

jkmassel · 2026-10-30T19:21:01Z

+                    .accessibilityHidden(true)
+            } else if showsDisclosureIndicator {
+                Spacer()
+                Image(systemName: "chevron.right")


Disclosure chevrons point the wrong way in right-to-left languages.

What happens: chevron.right doesn't flip. UIKit's .disclosureIndicator, which this replaces, did.

Who is affected: Arabic and Hebrew users.

Suggested change

Image(systemName: "chevron.right")

Image(systemName: "chevron.forward")

This PR With the suggestion

How this was checked: forced right-to-left layout with -AppleTextDirection YES, on this PR and with the suggestion. The merge base was not run for this one.

jkmassel · 2026-10-30T19:21:01Z

-            for (rowIndex, rowItem) in section.rows.enumerated() where rowItem.kind == row {
-                return IndexPath(row: rowIndex, section: sectionIndex)
-            }
+        guard let item = sections.lazy.flatMap(\.rows).first(where: { $0.kind == row }) else { return }


Not blocking: on iPad, a default row that appears later no longer opens.

What happens: this guard returns if the row isn't there yet. The old code remembered the row and opened it after the next reload.

Who is affected: probably nobody today. It needs a self-hosted site whose Stats row is missing at launch and appears later, and a sync never changes isAdmin for those sites.

What they see: nothing selected and an empty detail column. The merge base selects Stats and opens it.

Merge base This PR

How this was checked: isAdmin was set to false in the database, then flipped to true at runtime with a test hook, followed by a pull to refresh. No fix has been tested.

crazytonyli added this pull request to stack #26028 September 17, 2026 22:15

crazytonyli changed the title ~~task/blog details swiftui~~ Render blog details with a native SwiftUI list Sep 17, 2026

crazytonyli force-pushed the task/blog-details-swiftui branch 2 times, most recently from 47f3389 to 781d86d Compare September 18, 2026 01:04

crazytonyli commented Sep 18, 2026

View reviewed changes

crazytonyli added this to the 27.4 milestone Sep 18, 2026

crazytonyli marked this pull request as ready for review September 18, 2026 01:10

crazytonyli requested a review from jkmassel September 18, 2026 01:44

crazytonyli added the My Site label Sep 18, 2026

crazytonyli force-pushed the task/blog-details-swiftui branch from 781d86d to 2c1ab5b Compare September 24, 2026 08:52

crazytonyli mentioned this pull request Oct 12, 2026

iPad: reloading the site menu re-runs the selected custom post type row's action #26128

Open

wpmobilebot modified the milestones: 27.4, 27.5 Oct 20, 2026

crazytonyli force-pushed the task/blog-details-swiftui branch 2 times, most recently from 806722b to 44a9df0 Compare October 28, 2026 22:37

crazytonyli added 2 commits October 29, 2026 12:52

Prepare blog menu models for SwiftUI

8003853

Render blog details with a native SwiftUI list

c104b70

crazytonyli force-pushed the task/blog-details-swiftui branch from 44a9df0 to c104b70 Compare October 28, 2026 23:53

jkmassel requested changes Oct 30, 2026

View reviewed changes

	BlogDetailsHeader(controller: headerViewController)
	BlogDetailsHeader(controller: headerViewController)
	.id(headerEmbedID)

	var headerViewController: UIViewController?
	var headerViewController: UIViewController?
	var headerEmbedID = UUID()

-            stackView.insertArrangedSubview(header.view, at: 0)
+            let dashboardView = blogDashboardViewController?.view
+            let index =
+                stackView.arrangedSubviews.firstIndex { $0 === dashboardView } ?? stackView.arrangedSubviews.count
+            stackView.insertArrangedSubview(header.view, at: index)

-            add(blogDetailsViewController)
+            addChild(blogDetailsViewController)
+            view.insertSubview(blogDetailsViewController.view, aboveSubview: scrollView)
+            blogDetailsViewController.didMove(toParent: self)

	.id(viewModel.blog.objectID)
	.id(viewModel.blog.objectID)
	.id(viewModel.blog.jetpackConnectionActivePlugins)

	Image(systemName: "chevron.right")
	Image(systemName: "chevron.forward")

Conversation

crazytonyli commented Sep 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Testing instructions

Uh oh!

dangermattic commented Sep 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

wpmobilebot commented Sep 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

wpmobilebot commented Sep 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

wpmobilebot commented Oct 20, 2026

Uh oh!

jkmassel left a comment

Choose a reason for hiding this comment

Must fix

Should fix

Suggestions

How this was checked

Checked, no problem found

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

crazytonyli commented Sep 17, 2026 •

edited

Loading

dangermattic commented Sep 17, 2026 •

edited

Loading

wpmobilebot commented Sep 17, 2026 •

edited

Loading

wpmobilebot commented Sep 17, 2026 •

edited

Loading