Render blog details with a native SwiftUI list - #26026
Open
crazytonyli wants to merge 2 commits into
Open
crazytonyli wants to merge 2 commits into
crazytonyli wants to merge 2 commits into
Conversation
crazytonyli
added this pull request to stack #26028
September 17, 2026 22:15
Collaborator
Generated by 🚫 Danger |
Contributor
|
| App Name | WordPress | |
| Configuration | Release-Alpha | |
| Build Number | 34492 | |
| Version | PR #26026 | |
| Bundle ID | org.wordpress.alpha | |
| Commit | 781d86d | |
| Installation URL | 5v2b7p5aa2mb0 |
Contributor
|
| App Name | Jetpack | |
| Configuration | Release-Alpha | |
| Build Number | 34492 | |
| Version | PR #26026 | |
| Bundle ID | com.jetpack.alpha | |
| Commit | 781d86d | |
| Installation URL | 7tr7p84432ct8 |
crazytonyli
force-pushed
the
task/blog-details-swiftui
branch
from
September 17, 2026 23:44
0ce6540 to
47f3389
Compare
crazytonyli
force-pushed
the
task/blog-details-swiftui
branch
from
September 18, 2026 01:04
47f3389 to
781d86d
Compare
crazytonyli
commented
Sep 18, 2026
| return | ||
| } | ||
| if scrollView.contentOffset.y >= 60 { | ||
| if currentSection == .dashboard && scrollView.contentOffset.y >= 60 { |
Contributor
Author
There was a problem hiding this comment.
This is an intentional change. When the blog details is displayed standalone on WordPress, we no longer show or hide the navigation bar depending on scrolling positions. Toggling navigation bar messes with SwiftUI list and results in very confusing list jumps. I decided to remove the toggling, instead of working around the jumps.
crazytonyli
commented
Sep 18, 2026
| } header: { | ||
| if let title = section.title, !title.isEmpty { | ||
| Text(title) | ||
| } |
Contributor
Author
There was a problem hiding this comment.
Another small UI change: the header and footer now uses the default system layout, which has slightly large spacing than the old UIKit implementation. I think that's acceptable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Note
This PR will be merged after 27.3 code freeze, to give us a bit more time to test the changes during development.
Description
This prepares the site menu for SwiftUI destinations while keeping
BlogDetailsViewControlleras the UIKit entry point.List, including sidebar selection, badges, and section styling.Existing menu destinations retain UIKit routing. Native SwiftUI navigation for Comments follows in a separate PR.
Scrolling the site menu in My Site no longer reveals the navigation-bar title. Dashboard behavior is unchanged.
Testing instructions