Repository navigation
silk: add NEON optimized silk_LPC_analysis_filter for arm - #515
Open
Git-Donner wants to merge 1 commit into
Open
Git-Donner wants to merge 1 commit into
Git-Donner wants to merge 1 commit into
Conversation
Author
|
Hi maintainers, Just following up on this PR. All 6 GitHub Actions workflows are currently awaiting approval. Could a maintainer approve the workflows when convenient? I'd also appreciate any feedback or review on the implementation. Thanks :) |
Member
|
Is the PR AI-generated? If so, please let me know what you did and didn't do with the output. |
Author
|
Yes, AI (Deepseek) was used to assist with this PR. To clarify its involvement:
I did not submit the raw AI-generated output without review. I took responsibility for reviewing, modifying, debugging, and validating the final implementation. The final code and the reported test results are my responsibility. Thanks for bringing this up. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add an AArch64 NEON implementation of
silk_LPC_analysis_filter, achieving 2.8–3.4× speed-up over the scalar C reference on Kunpeng 920.Implementation
Validation
opus_demoround-trip completed successfully.-O3 -march=armv8-a). Ford=16, len=480, execution time decreased from 2759 ns to 814 ns per call.