Skip to content

Add mod thumbnails - #612

Open
zeroeightysix wants to merge 3 commits into
xivdev:testingfrom
zeroeightysix:testing
Open

zeroeightysix wants to merge 3 commits into
xivdev:testingfrom
zeroeightysix:testing

Conversation

@zeroeightysix

Copy link
Copy Markdown
Contributor

This PR adds mod thumbnails / preview images.

Since making my issue about this I've found @Ottermandias 's (old?) stance on thumbnails, so I've tried to get this as right as possible and not implement anything unnecessary.

What's in this PR?

  • Thumbnails show as a popup when hovering over mods in the list, and in the header (akin to how Heliosphere shows them).
  • Users can import a new thumbnail from clipboard or file picker. Files outside of the mod directory are copied into it.
  • The existing Mod.Image is used for thumbnails. There's no changes to the schema and no new config options.
  • Most of it is implemented as a new thumbnail service (critique on Image Preview #306)

Why thumbnails?

  • Going through glamourer is comparatively slower; a thumbnail gives you an instant impression of the mod.
  • Many players use sync plugins in tandem with Penumbra and Glamourer. Checking out a mod through Glamourer then means also showing it to others around them.
  • Most modders provide a pretty picture (gpose / edited screenshot) of their mod that
    • Shows of the intended vibe of the mod,
    • Gives a good idea of how the mod may be combined with other gearpieces etc,
    • and I like pretty pictures. It'd be a shame not to see them again after downloading the mod 😉
  • And a whole bunch of other reasons why I really like thumbnails, but there's plenty of words in this PR as-is
In-game screenshot image
AI Disclaimer I've developed this feature with the help of Antrophic's Claude Opus 5.5. I'd place it as "Assist" level looking at Dalamud's AI policy, having:
  • Used AI to refactor code to C# idioms / matching the codebase style,
  • Used it to find bugs (the change to the normalizer and the schema description were suggested by AI)
  • All code is written and structured by a human and thoroughly reviewed if not
  • None of the prose (PR description, issue, docs) is AI-generated

Supersedes #306
Closes #605

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Thumbnails for mods

1 participant