Repository navigation
feat: implement PartialEq on validation error types - #167
Merged
Merged
Conversation
dioxus の use_memo など PartialEq を要求する用途で validate() の結果を 扱えるよう、Errors / Error / Message / Format および各 *Error 型に PartialEq を derive する。 Closes #166 Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
ya7010
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PartialEqforErrors,Error,ArrayErrors,ObjectErrors,Message, and each*ErrortypeFormatcontainsMessageFn(a function pointer), soPartialEqis implemented manually using address comparison (fn_addr_eq). Identical functions are not guaranteed to compare equal; this is documented in a doc commentvalidate()usable wherePartialEqis required, e.g. dioxususe_memoCloses #166
Validation
cargo fmt -- --checkcargo clippy --workspace --all-features(no warnings)cargo test --all-features(all passing)🤖 Generated with Claude Code