Skip to content

Validate explicitly requested regulatory-target receipts, Fixes AB#3810655 - #2652

Draft
Mohammed El-Masry (melmasry) wants to merge 11 commits into
devfrom
mohaibrahim/msal-aa-target-validation-upstream
Draft

Mohammed El-Masry (melmasry) wants to merge 11 commits into
devfrom
mohaibrahim/msal-aa-target-validation-upstream

Conversation

@melmasry

@melmasry Mohammed El-Masry (melmasry) commented Nov 18, 2026 •

Copy link
Copy Markdown
Collaborator

Replaces fork draft #2645 with an upstream-hosted branch so repository pipelines can run. The old draft is left open for history.

Summary

Expose fail-closed regulatory-target receipt validation through the Android SDK, preserving generic additionalProperties transport and the distinct mismatch error. Explicit target-* entries in id_token.xms_agvs.additionalProperties opt in; untargeted requests remain unchanged.

The Common implementation checks the actual returned ID-token xms_agvt identity set at network, cache, broker, and Native Auth boundaries. Matching negative receipts establish binding, not adulthood or authorization. Access tokens remain opaque.

Dependencies and latest base

The upstream-targeted diff still includes pending preservation changes. Common must land before selecting its accepted release/dependency pin.

Decisions and merge gates

  1. Locked: cached receipt mismatch is terminal, before refresh-on scheduling; no automatic reacquisition, eviction, or validation bypass.
  2. Locked: preserve existing explicit-claims refresh behavior. This PR does not introduce claims-partitioned Android caching, an ID/refresh-token cache partition, or a new client-claims API.
  3. Open: SDK-owner agreement on responsibility, recovery, error contract, and mixed-version broker compatibility. Installing this library does not update an installed broker.

AB#3810655

Validation and blockers

Diff, ancestry, clean-state, and Common-pin checks passed. Current Gradle test/lint attempts stopped before execution because Java was unavailable to Gradle; Android SDK and Azure-feed credential configuration are also absent. No current compile/test/lint success is claimed. Authenticated CI, dependency review, and SDK-owner agreement are required before readiness.

<!-- BEGIN pr-telemetry -->
assistance: agentic-cli
type: feature
agent-tool: copilot-cli
agent-model: gpt-6-astra
work-item: [AB#3810655](https://identitydivision.visualstudio.com/fac9d424-53d2-45c0-91b5-ef6ba7a6bf26/_workitems/edit/3810655)
<!-- END pr-telemetry -->

Retain string properties through parsing, serialization, challenges and capability merges without changing essential/value/values behavior.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot-Session: 9a578d00-478b-4bfb-8ff5-843d86627760
Consume the shared validator through the established Common submodule and expose its client error without adding a feature switch or changing access-token handling.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot-Session: 9a578d00-478b-4bfb-8ff5-843d86627760
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot-Session: 9a578d00-478b-4bfb-8ff5-843d86627760
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot-Session: 9a578d00-478b-4bfb-8ff5-843d86627760
Keep local-flavor Common source linkage; no published dependency version is assumed.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot-Session: 9a578d00-478b-4bfb-8ff5-843d86627760
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 9a578d00-478b-4bfb-8ff5-843d86627760
Retain preservation PR #2651 and its release changes. Resolve the Common dependency to refreshed dev-based target validation 579e175c5bebcaf3a7ec92605d556a1e9df18573.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot-Session: 9a578d00-478b-4bfb-8ff5-843d86627760
Clarify that the xms_agvt prefix represents an outcome, not token signature validation, and cached mismatches do not automatically reacquire or bypass validation. Retain recovery, broker compatibility, and shared-cache boundaries as SDK-owner rollout gates.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot-Session: 9a578d00-478b-4bfb-8ff5-843d86627760
Use Common 94f99b78ab34d95631e60a114b42b8a59402bb21, including both local and Native Auth fail-closed refresh-on boundaries.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot-Session: 9a578d00-478b-4bfb-8ff5-843d86627760
@melmasry Mohammed El-Masry (melmasry) added changelog:minor Backward-compatible feature that requires a minor version increment. agentic-cli feature New functionality labels Nov 18, 2026
@github-actions github-actions Bot changed the title Validate explicitly requested regulatory-target receipts Validate explicitly requested regulatory-target receipts, Fixes AB#3810655 Nov 18, 2026
@github-actions

Copy link
Copy Markdown

✅ Work item link check complete. Description contains link AB#3810655 to an Azure Boards work item.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agentic-cli changelog:minor Backward-compatible feature that requires a minor version increment. feature New functionality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant