Repository navigation
Validate explicitly requested regulatory-target receipts, Fixes AB#3810655 - #2652
Draft
Mohammed El-Masry (melmasry) wants to merge 11 commits into
Draft
Mohammed El-Masry (melmasry) wants to merge 11 commits into
Mohammed El-Masry (melmasry) wants to merge 11 commits into
Conversation
Retain string properties through parsing, serialization, challenges and capability merges without changing essential/value/values behavior. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 9a578d00-478b-4bfb-8ff5-843d86627760
Consume the shared validator through the established Common submodule and expose its client error without adding a feature switch or changing access-token handling. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 9a578d00-478b-4bfb-8ff5-843d86627760
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 9a578d00-478b-4bfb-8ff5-843d86627760
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 9a578d00-478b-4bfb-8ff5-843d86627760
Keep local-flavor Common source linkage; no published dependency version is assumed. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 9a578d00-478b-4bfb-8ff5-843d86627760
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 9a578d00-478b-4bfb-8ff5-843d86627760
Retain preservation PR #2651 and its release changes. Resolve the Common dependency to refreshed dev-based target validation 579e175c5bebcaf3a7ec92605d556a1e9df18573. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 9a578d00-478b-4bfb-8ff5-843d86627760
Clarify that the xms_agvt prefix represents an outcome, not token signature validation, and cached mismatches do not automatically reacquire or bypass validation. Retain recovery, broker compatibility, and shared-cache boundaries as SDK-owner rollout gates. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 9a578d00-478b-4bfb-8ff5-843d86627760
Use Common 94f99b78ab34d95631e60a114b42b8a59402bb21, including both local and Native Auth fail-closed refresh-on boundaries. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 9a578d00-478b-4bfb-8ff5-843d86627760
|
✅ Work item link check complete. Description contains link AB#3810655 to an Azure Boards work item. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces fork draft #2645 with an upstream-hosted branch so repository pipelines can run. The old draft is left open for history.
Summary
Expose fail-closed regulatory-target receipt validation through the Android SDK, preserving generic
additionalPropertiestransport and the distinct mismatch error. Explicittarget-*entries inid_token.xms_agvs.additionalPropertiesopt in; untargeted requests remain unchanged.The Common implementation checks the actual returned ID-token
xms_agvtidentity set at network, cache, broker, and Native Auth boundaries. Matching negative receipts establish binding, not adulthood or authorization. Access tokens remain opaque.Dependencies and latest base
commonpins published commit94f99b78ab34d95631e60a114b42b8a59402bb21.devatf750efd413425291401c47aa041bd0e684d685f8and the current preservation head; retained generic fixtures.The upstream-targeted diff still includes pending preservation changes. Common must land before selecting its accepted release/dependency pin.
Decisions and merge gates
AB#3810655
Validation and blockers
Diff, ancestry, clean-state, and Common-pin checks passed. Current Gradle test/lint attempts stopped before execution because Java was unavailable to Gradle; Android SDK and Azure-feed credential configuration are also absent. No current compile/test/lint success is claimed. Authenticated CI, dependency review, and SDK-owner agreement are required before readiness.