Repository navigation
Validate explicitly requested age-assurance target receipts - #3350
Draft
Mohammed El-Masry (melmasry) wants to merge 8 commits into
Draft
Mohammed El-Masry (melmasry) wants to merge 8 commits into
Mohammed El-Masry (melmasry) wants to merge 8 commits into
Conversation
Validate explicit ID-token targets before network/native persistence and cached or broker success delivery. Preserve untargeted behavior and signed outcome semantics without interpreting status or authorizing API access. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 9a578d00-478b-4bfb-8ff5-843d86627760
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 9a578d00-478b-4bfb-8ff5-843d86627760
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 9a578d00-478b-4bfb-8ff5-843d86627760
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 9a578d00-478b-4bfb-8ff5-843d86627760
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 9a578d00-478b-4bfb-8ff5-843d86627760
Validate a cached local result before refresh-on can schedule background acquisition. Cover exact array/string request opt-in and both local cache-hit branches; clarify fail-closed recovery and shared cache boundaries. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 9a578d00-478b-4bfb-8ff5-843d86627760
Reject a mismatched cached ID token before Native Auth schedules refresh-on, matching the local controller boundary. Exercise both controllers and both cache-hit branches through the shared regression fixture. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 9a578d00-478b-4bfb-8ff5-843d86627760
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Proposes request-bound regulatory-target receipt validation for explicit
target-*strings in theid_token.xms_agvs.additionalPropertiesarray. Validate the returned ID-tokenxms_agvtcomma-separated identity set, ignoring case/order. Missing, malformed, duplicate, extra, or wrong identities fail withage_assurance_target_mismatch, including atxms_agvs=0.The
+/-prefixes describe outcomes, not cryptographic signatures. A matching negative receipt is valid binding, not adulthood or authorization.allis literal; access tokens remain opaque; untargeted requests retain existing behavior.Network, cached, broker, command-dispatch, and Native Auth result boundaries retain operation-local request binding. Local and Native Auth cache hits now reject mismatches before refresh-on scheduling. Regression coverage asserts no refresh dispatch, token request, or cache removal after a mismatch.
Cache contract and decisions
Dependencies and latest base
Merged upstream
devat5a8845a1a266cf174aeb67ff41569a588caaf413. Coordinate with Android wrapper validation AzureAD/microsoft-authentication-library-for-android#2652 and preservation https://github.com/AzureAD/microsoft-authentication-library-for-android/pull/2651. Preservation must land before the coordinated rollout.Primary Android PBI: AB#3826674
Related cross-SDK task: AB#3810655
Validation and blockers
Diff, ancestry, and static checks passed. Current focused Gradle test/lint attempts stopped before execution because Java was unavailable to Gradle; Android SDK and Azure-feed credential configuration are also absent. No current compile, unit-test, or lint pass is claimed. Authenticated Android/JDK CI remains required.
Draft only: design gates and required CI remain open.