Repository navigation
Expose request-bound age-assurance target validation - #2645
Draft
Mohammed El-Masry (melmasry) wants to merge 6 commits into
Draft
Mohammed El-Masry (melmasry) wants to merge 6 commits into
Mohammed El-Masry (melmasry) wants to merge 6 commits into
Conversation
Retain string properties through parsing, serialization, challenges and capability merges without changing essential/value/values behavior. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 9a578d00-478b-4bfb-8ff5-843d86627760
Consume the shared validator through the established Common submodule and expose its client error without adding a feature switch or changing access-token handling. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 9a578d00-478b-4bfb-8ff5-843d86627760
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 9a578d00-478b-4bfb-8ff5-843d86627760
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 9a578d00-478b-4bfb-8ff5-843d86627760
Keep local-flavor Common source linkage; no published dependency version is assumed. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 9a578d00-478b-4bfb-8ff5-843d86627760
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 9a578d00-478b-4bfb-8ff5-843d86627760
|
Mohammed El-Masry (@melmasry) please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
Contributor License AgreementContribution License AgreementThis Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Exposes the proposed
age_assurance_target_mismatcherror and pins Common's request-bound age-assurance target validation. Adds exception-mapping coverage. Runtime parsing and validation live in the companion Common change.Explicit
target-*strings in theid_token.xms_agvs.additionalPropertiesarray opt in. Requested suffix identities must match the returned ID-tokenxms_agvtcomma-separated receipt, ignoring case/order. Entries require a+or-outcome prefix, not a cryptographic signature. Missing, malformed, duplicate, extra, or wrong identities reject, including atxms_agvs=0. Negative matches are not adulthood or authorization;allis literal; access tokens remain opaque.Dependencies and merge gate
Draft: do not merge until both prerequisites have merged:
This upstream-targeted draft includes the preservation changes. Validation-only scope is three files relative to published preservation head
575cfd303f4ea6517382f589987ef99ab0bcf1b4: Common gitlink, public error constant/documentation, and exception-mapping test.Common is pinned to published validation commit
80dbec5bb999addeb665ac05a8e08ae26961933c. Repin to the accepted upstream Common commit after merge and rerun checks. No fabricated dependency version is introduced. Maintainer acceptance of SDK responsibility and release sequencing remains pending.Validation and blockers
Thirteen isolated claims/WWW-Authenticate JUnit tests passed against actual sources; these cover preservation, not the integrated validation behavior. Static diff, ancestry, and gitlink checks passed.
Integrated wrapper tests are blocked by uncached Gradle plugins. Common tests are blocked during settings evaluation by unavailable feed credentials; Android SDK prerequisites are unavailable locally. Integrated build, lint, device/broker/Native Auth, and end-to-end gates remain outstanding.