Repository navigation
[IMPROVEMENT] Add tests for the input and output format options - #2411
Open
Deepak-negi11 wants to merge 3 commits into
Open
Deepak-negi11 wants to merge 3 commits into
Deepak-negi11 wants to merge 3 commits into
Conversation
5 of 7 tasks
Deepak-negi11
force-pushed
the
test/cli-format-options
branch
from
October 24, 2026 23:04
96856e2 to
00bdb69
Compare
Collaborator
CCExtractor CI platform finished running the test files on windows. 171/237 tests matched the approved output:
66 tests do not match the approved output. That is the pass/fail verdict. Whether this branch caused it is a separate question, answered below.
Compared with the tip of master — test 9693, commit af4b28d:
Fail on both but produce different output — behaviour moved even though the verdict did not:
Fail there, pass here:
Compared with the commit this branch was cut from: the same run as the tip of master (test 9693), so the comparison above already covers it. This branch changes the behaviour of 42 test(s) relative to the tip of master. Those are the ones worth looking at; anything else in the list fails the same way on both sides. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In raising this pull request, I confirm the following (please check boxes):
Reason for this PR:
Sanity check:
Repro instructions:
cd src/rust && cargo test --lib cli_testsExample of what the new tests catch: turn
--srtoff (changeif args.srttoif falsewhereset_output_formatis called inparser.rs). The other 442 tests pass;test_output_format_options_reach_cfails. SRT is also the default, so the test checkswrite_format_rewrittentoo.Part of #2408 (step 3). Depends on #2409 and #2410.
Problem
15 options had no test that passes them on the command line: the input format flags and several output options.
What this adds
Tests that check the C settings for both the new (
--ts) and old (-ts) spelling:--es,--ts,--ps,--asf,--dvr-ms,--wtv,--mp4,--mkvset the C demuxer mode (demux_cfg.auto_stream).--srt,--sami,--dvdraw,--mcc,--nullsetwrite_format;--null-terminatedsetsframe_terminator_0;--report-format JSONsetsreport_formattojson.These 15 are removed from
UNTESTED_OPTIONS, which goes from 24 to 10.Testing
cargo test(442 passed),cargo fmt --check,cargo clippy -- -D warnings.