Repository navigation
Add Reimbursable setting to company card feeds - #104160
youssef-lr wants to merge 26 commits into
Conversation
|
Hey, I noticed you changed If you want to automatically generate translations for other locales, an Expensify employee will have to:
Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running: npx bun ./scripts/generateTranslations.ts --helpTypically, you'd want to translate only what you changed by running |
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
…rated translations
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 904d55d196
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
…ates - Prefer pending/errored local direct-feed forceReimbursable over stale OAuth values in getCombinedCardFeedsFromAllFeeds - Preserve the kept managed card's imported reimbursable value in compareDuplicateTransactionFields instead of forcing false - Add regression tests for both
…setting-company' into app-103342-add-reimbursable-setting-company
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| } | ||
| } | ||
|
|
||
| // Use the local reimbursable value during pending or failed saves; the OAuth value may be stale. |
There was a problem hiding this comment.
❌ CONSISTENCY-15 (docs)
This comment joins two independent clauses with a semicolon, which the plain-comment-style rule calls out. Comments should read as plain, separate sentences.
Split it into two sentences:
// Use the local reimbursable value during pending or failed saves. The OAuth value may be stale.Reviewed at: 18237d8 | Please rate this suggestion with 👍 or 👎 to help us improve! Reactions are used to monitor reviewer efficiency.
| }; | ||
|
|
||
| if (isLoadingOnyxValue(cardFeedsResult) || isLoadingOnyxValue(lastSelectedFeedResult)) { | ||
| return <FullScreenLoadingIndicator />; |
There was a problem hiding this comment.
❌ UI-1 (docs)
This early-return renders FullscreenLoadingIndicator with no navigation component (no HeaderWithBackButton) in the same branch, so if loading hangs the user has no way to escape. When no navigation is visible, FullscreenLoadingIndicator must set shouldUseGoBackButton so the emergency "Go Back" button appears after a timeout.
if (isLoadingOnyxValue(cardFeedsResult) || isLoadingOnyxValue(lastSelectedFeedResult)) {
return <FullScreenLoadingIndicator shouldUseGoBackButton />;
}Reviewed at: 18237d8 | Please rate this suggestion with 👍 or 👎 to help us improve! Reactions are used to monitor reviewer efficiency.
|
🚧 joekaufmanexpensify has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 18237d89f0
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
…rsable-setting-company # Conflicts: # src/libs/Navigation/types.ts
BUG: unable to change setting on shared feedSteps:
Expected resultYou're able to adjust the setting and it applies everywhere the feed is shown. Actual resultWe show a generic API error, and the setting is not changed. Logs. 2026-10-19_13-38-25.mp4 |
|
It will need a fix in Auth. Working on it now. |
|
Thanks! Otherwise, the setting is working really well. |
|
Please ping me when that all change is done, and I will retest. 🫡 |
This branch has not been deployed
2 participants
Explanation of Change
Let admins choose the Reimbursable rule from company card feed settings. Add the four choices used for cash expenses and show setting changes in the workspace admins room.
Fixed Issues
$ #103342
PROPOSAL:
Tests
Planned manual tests (not yet completed):
Offline tests
Planned offline test (not yet run):
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Screen.Recording.2026-10-19.at.16.33.27.mov