Repository navigation
Add Reimbursable setting to company card feeds #104160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
youssef-lr
wants to merge
26
commits into
Expensify:main
Choose a base branch
from
youssef-lr:app-103342-add-reimbursable-setting-company
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+4,872
−930
Open
Changes from all commits
Commits
Show all changes
26 commits
Select commit
Hold shift + click to select a range
28bd2ce
Add SetFeedReimbursable API command and action
youssef-lr eabe1cd
Add company card feed Reimbursable selection page and route
youssef-lr 65a99ba
Add Reimbursable row to company card feed settings
youssef-lr f05ce6f
Add change log for company card feed Reimbursable setting
youssef-lr 47e443f
Add non-English translations for company card feed Reimbursable setting
youssef-lr 1a40c5a
Shorten Reimbursable route param type to satisfy max-lines
youssef-lr 86922b1
Revert non-English translations for Reimbursable setting pending gene…
youssef-lr c7b54d9
Show and clear Reimbursable save errors on company card feed page
youssef-lr 27b1d06
Remove manual memoization from company card Reimbursable setting
youssef-lr 9037ef1
Centralize company card feed Reimbursable normalization in CardUtils
youssef-lr b04a019
Share selectable Reimbursable type and ignore unrecognized server values
youssef-lr ecbc392
Localize Reimbursable change log when previous value is missing
youssef-lr 14ca9f1
Flatten Reimbursable page description Text
youssef-lr c6504e4
Add tests for Reimbursable feed save, optimistic and failure behavior
youssef-lr da0c76f
Remove double cast from Reimbursable unrecognized-value test
youssef-lr 904d55d
Merge branch 'main' into app-103342-add-reimbursable-setting-company
youssef-lr da6e8b9
Keep local Reimbursable feed changes and managed card value on duplic…
youssef-lr a93b67d
Merge remote-tracking branch 'youssef-lr/app-103342-add-reimbursable-…
youssef-lr 422fb2a
Make card feed errorFields partial
youssef-lr 148aa23
Clarify comment
youssef-lr 7fd9dcc
Clarify comments
youssef-lr 18237d8
Merge branch 'main' into app-103342-add-reimbursable-setting-company
youssef-lr 0e80620
Merge remote-tracking branch 'origin/main' into app-103342-add-reimbu…
youssef-lr afe5d92
Add company card reimbursable screen to relocated workspace param list
youssef-lr aeef729
Clarify imported reimbursable comment
youssef-lr bfe905e
Merge origin/main into add-reimbursable-setting and add missing trans…
youssef-lr File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.