Repository navigation
Fix Windows CUDA builds and CMake installation - #113
Open
LucasBoTang wants to merge 3 commits into
Open
LucasBoTang wants to merge 3 commits into
LucasBoTang wants to merge 3 commits into
Conversation
This was referenced Oct 27, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks @brynpickering for tracking down the Windows build issues in conda-forge/cupdlpx-feedstock#1.
This adds the same compiler fix upstream: enable
/Zc:preprocessorfor CUDA 13+ on MSVC. CUDA 12 keeps the flag disabled because it causes CUB/Thrust errors when building for all architectures.While testing this locally, I also found and fixed a few CMake issues:
/O2conflicted with/RTC1. Use CMake's optimization flags for each build type.CUDA_ARCHITECTURES=all, detect newly added source files, and let CMake detect the HIP architecture unless one is specified.Windows builds passed with CUDA 12.9 and 13.4. All 107 Python tests passed on CUDA 12.9, as did a Debug build. Linux build and installation checks passed with CUDA 13.3 and CMake 3.23.5, including custom install directories and relocation.
CUDA 13.4 passed the basic solve tests, but the full suite hit a separate reduction buffer sizing bug. That fix will be handled separately.