Method rpc annotation can define a Target Client parameter - #102
Open
TheDavSmasher wants to merge 16 commits into
Open
TheDavSmasher wants to merge 16 commits into
TheDavSmasher wants to merge 16 commits into
Conversation
miniduikboot
requested changes
Sep 4, 2026
miniduikboot
left a comment
miniduikboot
left a comment
Collaborator
There was a problem hiding this comment.
Could you add a piece of example code to Reactor.Example that uses a targeted RPC?
| il.Emit(OpCodes.Stelem_Ref); | ||
| } | ||
|
|
||
| if (targetClientIndex >= 0) |
Collaborator
There was a problem hiding this comment.
TODO: review this IL code, as I'm not familiar with it
Author
|
Done |
XtraCube
suggested changes
Sep 29, 2026
AlchlcDvl
suggested changes
Sep 30, 2026
Author
|
If I can improve this (ie when I'm back home), I think a second constructor that targets the Host only would be useful (since Host-only RPCs aren't uncommon). |
Author
|
Added a second option for the rpc to instead be sent to specifically the host since host-only targeted rpcs are common enough to warrant having it |
AlchlcDvl
suggested changes
Oct 1, 2026
Author
|
I believe unless further changes are requested, I cannot think of more for this PR |
AlchlcDvl
suggested changes
Oct 1, 2026
Author
|
waaa |
AlchlcDvl
approved these changes
Oct 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Expands the existing MethodRpc annotation so a parameter of the method it is annotating can be assigned to mark the "TargetClientId" that SendRpcImmediately uses to not broadcast rpc to all.
Also added an option so the RPC is only sent to the Host of the room automatically.