Repository navigation
Method rpc annotation can define a Target Client parameter #102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
TheDavSmasher
wants to merge
17
commits into
NuclearPowered:master
Choose a base branch
from
TheDavSmasher:method-rpc-target-client
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
c34bc8c
Updated .gitignore
TheDavSmasher 5bf3322
Added way to define a paramter as a target client
TheDavSmasher 8656da0
Injected necessary IL to pass additional parameter
TheDavSmasher ff5f44c
Fixed wrong constructor structure for annotation
TheDavSmasher 206261f
Added example Rpc with target
TheDavSmasher 17ed3f9
Added isStatic offset to emitted ldarg
TheDavSmasher 2465d25
Changed to use InnerNetObject.OwnerId
TheDavSmasher bb974f1
Changed to use property getter instead of field
TheDavSmasher b062658
Removed redundant constructor with default parameter
TheDavSmasher 9b63872
Added default parameters
TheDavSmasher 7482d98
Added HostOnly option for MethodRpc
TheDavSmasher fd2250a
Changed to throw exception if defined as both host only and to have a…
TheDavSmasher c4419f9
Added example of Host-only rpc
TheDavSmasher 65337ea
Returned default constructor for clarity
TheDavSmasher 748ee9d
oopsie I forgored something
TheDavSmasher 678f8d7
Curse reflection forever
TheDavSmasher 89099c0
Changed Boolean statement
TheDavSmasher File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -5,5 +5,5 @@ riderModule.iml | |
| /_ReSharper.Caches/ | ||
| .idea | ||
| /tools | ||
| .vscode | ||
| .vs* | ||
| *.DotSettings.user | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -4,4 +4,6 @@ public enum CustomRpcCalls : uint | |
| { | ||
| Example, | ||
| MethodRpcExample, | ||
| TargetRpcExample, | ||
| HostRpcExample, | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.