Repository navigation
Conversation
This was referenced Oct 13, 2026
Member
Author
|
jenkins build this opm-simulators=7549 opm-tests=1661 please |
GitPaean
force-pushed
the
manifold-group-outlet-vfp
branch
from
October 15, 2026 07:20
51b6cb1 to
7784b86
Compare
GitPaean
force-pushed
the
manifold-group-outlet-vfp
branch
from
October 30, 2026 15:33
7784b86 to
642dc92
Compare
GitPaean
force-pushed
the
manifold-group-outlet-vfp
branch
from
November 18, 2026 09:04
642dc92 to
dcdca8a
Compare
A well group declared as a choke in NODEPROP is a sub-sea manifold: its wells share a common THP, while its outlet branch can still carry the pressure losses of the flow line.
The choke group set by NODEPROP was neither serialized nor compared, so on all processes but the one reading the deck no group served as a choke, and parallel runs could call mismatched collectives. Cover it, and the choke target of a network node, in the serialization test objects.
GitPaean
force-pushed
the
manifold-group-outlet-vfp
branch
from
November 18, 2026 09:43
dcdca8a to
00eb800
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A well group declared a sub-sea manifold in NODEPROP (item 3) may have a VFP table on its outlet branch. The table then gives the unchoked nodal pressure of the manifold, while the choke acts on the common THP of its wells. The parser rejected such a branch with "Node: B1 should serve as a choke => upstream branch can not have VFP table"; it now accepts it, and
NetworkTestscovers the case.The second commit serializes the choke group of a group (
Group::m_choke_group, set by NODEPROP). It was neither serialized nor compared, so on all processes but the one reading the deck no group served as a choke, and a parallel run with an auto-choke group could call mismatched collectives:NETWORK_MODEL5_STDW_AUTOCHK_GROUPGUIDERATESaborts withMPI_ERR_TRUNCATEon two processes, also on master. The serialization test objects now set it, as well as the choke target of a network node, sotest_Serializationfails without the fix.Used by OPM/opm-simulators#7549, with the test case in OPM/opm-tests#1661.