Skip to content

Allow a VFP table on the outlet branch of a sub-sea manifold group - #5470

Draft
GitPaean wants to merge 2 commits into
OPM:masterfrom
GitPaean:manifold-group-outlet-vfp
Draft

GitPaean wants to merge 2 commits into
OPM:masterfrom
GitPaean:manifold-group-outlet-vfp

Conversation

@GitPaean

@GitPaean GitPaean commented Oct 13, 2026 •

Copy link
Copy Markdown
Member

A well group declared a sub-sea manifold in NODEPROP (item 3) may have a VFP table on its outlet branch. The table then gives the unchoked nodal pressure of the manifold, while the choke acts on the common THP of its wells. The parser rejected such a branch with "Node: B1 should serve as a choke => upstream branch can not have VFP table"; it now accepts it, and NetworkTests covers the case.

The second commit serializes the choke group of a group (Group::m_choke_group, set by NODEPROP). It was neither serialized nor compared, so on all processes but the one reading the deck no group served as a choke, and a parallel run with an auto-choke group could call mismatched collectives: NETWORK_MODEL5_STDW_AUTOCHK_GROUPGUIDERATES aborts with MPI_ERR_TRUNCATE on two processes, also on master. The serialization test objects now set it, as well as the choke target of a network node, so test_Serialization fails without the fix.

Used by OPM/opm-simulators#7549, with the test case in OPM/opm-tests#1661.

@GitPaean GitPaean added the manual:enhancement This is an enhancement/improvent that needs to be documented in the manual label Oct 13, 2026
@GitPaean

GitPaean commented Oct 13, 2026 •

Copy link
Copy Markdown
Member Author

jenkins build this opm-simulators=7549 opm-tests=1661 please

https://ci.opm-project.org/job/opm-common-PR-builder/10632/

@GitPaean
GitPaean force-pushed the manifold-group-outlet-vfp branch from 51b6cb1 to 7784b86 Compare October 15, 2026 07:20
@GitPaean
GitPaean force-pushed the manifold-group-outlet-vfp branch from 7784b86 to 642dc92 Compare October 30, 2026 15:33
@GitPaean
GitPaean force-pushed the manifold-group-outlet-vfp branch from 642dc92 to dcdca8a Compare November 18, 2026 09:04
A well group declared as a choke in NODEPROP is a sub-sea manifold: its
wells share a common THP, while its outlet branch can still carry the
pressure losses of the flow line.
The choke group set by NODEPROP was neither serialized nor compared, so
on all processes but the one reading the deck no group served as a
choke, and parallel runs could call mismatched collectives. Cover it,
and the choke target of a network node, in the serialization test
objects.
@GitPaean
GitPaean force-pushed the manifold-group-outlet-vfp branch from dcdca8a to 00eb800 Compare November 18, 2026 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

manual:enhancement This is an enhancement/improvent that needs to be documented in the manual

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant