Skip to content

Fix the group control of sub-sea manifold groups - #7549

Draft
GitPaean wants to merge 9 commits into
OPM:masterfrom
GitPaean:manifold-group-outlet-vfp
Draft

GitPaean wants to merge 9 commits into
OPM:masterfrom
GitPaean:manifold-group-outlet-vfp

Conversation

@GitPaean

Copy link
Copy Markdown
Member

Fixes the group control of sub-sea manifold groups (NODEPROP item 3 on a well group): the wells of such a group produce against a common THP, which a choke raises to bring the group down to its rate target. On master, NETWORK_MODEL5_STDW_AUTOCHK throws on the control mode NONE, NETWORK_MODEL5_STDW_AUTOCHK_GROUPGUIDERATES asserts in TargetCalculator, and a manifold with a VFP table on its outlet branch is rejected by the parser (OPM/opm-common#5470).

  • Target. No well targets a manifold group, so its control mode was reset to NONE and the target lookup threw; a manifold following an ancestor's target asserted on FLD. The target now comes from the mode set in GCONPROD, or from the ancestor whose target is passed down, and the group is kept out of the NONE reset.
  • Add-back. A manifold below its share has no group controlled wells, so its own rate counted in the reductions above it and the group settled at a fraction of its share. Its rate is now added back.
  • Node pressure. The node pressure follows from the outlet branch, with or without a VFP table, and the wells produce against the common THP or the node pressure, whichever is higher.
  • THP solve. The rate at a trial THP follows from each well's inflow at the current reservoir state and its VFP table, within its rate limits, summed over all processes. Full well solves at each trial THP did not converge near the operability limit, so no THP was found and the target was ignored. The THP-limited rate is searched evenly in rate: the general BHP(THP) bracketing steps over the narrow operating window of a highly productive well.
  • Wells that cannot flow. A well at its operability limit was stopped by its own solve, the THP then fell for the remaining wells, and the well reopened at the next iteration, again and again until the time step was cut to its minimum. The THP solve now decides which wells cannot flow, also when the target falls within the drop in group rate as a well stops, and keeps them stopped for the time step; they are closed at its end like any well that cannot operate. A stop decided on a state not yet converged may be undone once.
  • Tests. The three auto-choke decks are registered as regression tests with the default tuning; Auto choke tests #5845 registers two of them with --enable-tuning=true. test_networkpressure covers the node pressure of a manifold, and the expected target in test_group_higher_constraints includes the add-back.

Newton iterations / chopped time steps over the whole run:

Deck Before the last two commits This PR This PR, --enable-tuning=true
NETWORK_MODEL5_STDW_AUTOCHK 450 / 9 152 / 0 213 / 0
NETWORK_MODEL5_STDW_AUTOCHK_GROUPGUIDERATES 167 / 2 117 / 0 155 / 0
NETWORK_MODEL5_STDW_AUTOCHK_WITHVFP 378 / 6 213 / 0 261 / 0

Before the last two commits all three aborted with --enable-tuning=true. All three now also run on 2 and 4 processes. Network decks without a manifold group give results identical to master (NETWORK-01, NETWORK-01-WTEST, NETWORK-01-REROUTE, 5_NETWORK_MODEL5_STDW, GASLIFT-13).

Requires OPM/opm-common#5470 and OPM/opm-tests#1661.

The wells of a manifold group are on THP control, so no well targets the
group: its control mode was reset to NONE and the target lookup threw,
while a manifold following an ancestor's target asserted on FLD. Use the
mode set in GCONPROD, or the mode of the ancestor whose target is passed
down, and keep that group out of the NONE reset. Groups without rates
are skipped in the underperformance check, as after a chopped first
time step.
A manifold below its share has no group controlled wells, so its own
rate is part of the reductions above it. Without the add-back its target
fell as its rate rose, and the group settled at a fraction of its share.
The node pressure follows from the outlet branch, with or without a VFP
table, and the wells of the group produce against its common THP or the
node pressure, whichever is higher.
Solving the well equations at each trial THP did not converge for wells
close to their operability limit, so no THP was found and the group
target was ignored. The rate at a trial THP now follows from the inflow
at the current reservoir state and the VFP table, within the rate limits
of the well, summed over all ranks. All producers of the group are then
solved against the new THP, and the group rates are updated before the
network pressures are computed from them.
A highly productive well goes from its cut back rate to no flow over a
BHP range narrow enough for the bracketing of the general BHP(THP)
solver to step over the operating window, taking a well that can flow
as dead. Return no rates, rather than zero rates, for a well that
cannot flow.
At its operability limit a well was stopped by its own solve, the
common THP then fell for the remaining wells, and the well was reopened
at the next iteration, again and again until the time step was cut to
its minimum. Decide in the THP solve which wells cannot flow, also
where the group target falls within the drop in rate as a well stops,
and keep them stopped for the time step; they are closed at its end as
any well that cannot operate. A stop decided on a state not yet
converged may be undone once.
@GitPaean
GitPaean force-pushed the manifold-group-outlet-vfp branch from 290fd38 to 6150452 Compare November 18, 2026 09:04
The rate of a well at a trial common THP was cut back to the rate limits
scheduled for it, without the drawdown limit WELDRAW adds at run time,
so the THP solve could count on more flow than the well delivers and
choke the group below its target.
The groups kept out of the NONE reset were found from the scheduled
control modes, so a manifold, or an ancestor, scheduled as FLD that had
switched to one of its own limits was reset to NONE at the end of the
time step, and the next THP solve followed the target above it. Find
them from the current modes, as the THP solve takes its target.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

manual:enhancement This is an enhancement/improvent that needs to be documented in the manual

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant