Repository navigation
Conversation
This was referenced Oct 13, 2026
GitPaean
force-pushed
the
manifold-group-outlet-vfp
branch
from
October 15, 2026 07:20
69e3a35 to
51455f2
Compare
GitPaean
force-pushed
the
manifold-group-outlet-vfp
branch
from
October 30, 2026 15:37
51455f2 to
290fd38
Compare
This was referenced Nov 18, 2026
The wells of a manifold group are on THP control, so no well targets the group: its control mode was reset to NONE and the target lookup threw, while a manifold following an ancestor's target asserted on FLD. Use the mode set in GCONPROD, or the mode of the ancestor whose target is passed down, and keep that group out of the NONE reset. Groups without rates are skipped in the underperformance check, as after a chopped first time step.
A manifold below its share has no group controlled wells, so its own rate is part of the reductions above it. Without the add-back its target fell as its rate rose, and the group settled at a fraction of its share.
The node pressure follows from the outlet branch, with or without a VFP table, and the wells of the group produce against its common THP or the node pressure, whichever is higher.
Solving the well equations at each trial THP did not converge for wells close to their operability limit, so no THP was found and the group target was ignored. The rate at a trial THP now follows from the inflow at the current reservoir state and the VFP table, within the rate limits of the well, summed over all ranks. All producers of the group are then solved against the new THP, and the group rates are updated before the network pressures are computed from them.
A highly productive well goes from its cut back rate to no flow over a BHP range narrow enough for the bracketing of the general BHP(THP) solver to step over the operating window, taking a well that can flow as dead. Return no rates, rather than zero rates, for a well that cannot flow.
At its operability limit a well was stopped by its own solve, the common THP then fell for the remaining wells, and the well was reopened at the next iteration, again and again until the time step was cut to its minimum. Decide in the THP solve which wells cannot flow, also where the group target falls within the drop in rate as a well stops, and keep them stopped for the time step; they are closed at its end as any well that cannot operate. A stop decided on a state not yet converged may be undone once.
GitPaean
force-pushed
the
manifold-group-outlet-vfp
branch
from
November 18, 2026 09:04
290fd38 to
6150452
Compare
The rate of a well at a trial common THP was cut back to the rate limits scheduled for it, without the drawdown limit WELDRAW adds at run time, so the THP solve could count on more flow than the well delivers and choke the group below its target.
The groups kept out of the NONE reset were found from the scheduled control modes, so a manifold, or an ancestor, scheduled as FLD that had switched to one of its own limits was reset to NONE at the end of the time step, and the next THP solve followed the target above it. Find them from the current modes, as the THP solve takes its target.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the group control of sub-sea manifold groups (NODEPROP item 3 on a well group): the wells of such a group produce against a common THP, which a choke raises to bring the group down to its rate target. On master,
NETWORK_MODEL5_STDW_AUTOCHKthrows on the control mode NONE,NETWORK_MODEL5_STDW_AUTOCHK_GROUPGUIDERATESasserts inTargetCalculator, and a manifold with a VFP table on its outlet branch is rejected by the parser (OPM/opm-common#5470).--enable-tuning=true.test_networkpressurecovers the node pressure of a manifold, and the expected target intest_group_higher_constraintsincludes the add-back.Newton iterations / chopped time steps over the whole run:
--enable-tuning=trueNETWORK_MODEL5_STDW_AUTOCHKNETWORK_MODEL5_STDW_AUTOCHK_GROUPGUIDERATESNETWORK_MODEL5_STDW_AUTOCHK_WITHVFPBefore the last two commits all three aborted with
--enable-tuning=true. All three now also run on 2 and 4 processes. Network decks without a manifold group give results identical to master (NETWORK-01,NETWORK-01-WTEST,NETWORK-01-REROUTE,5_NETWORK_MODEL5_STDW,GASLIFT-13).Requires OPM/opm-common#5470 and OPM/opm-tests#1661.