Conversation
Require the reissue payload to consume all bytes before OP_DROP. This rejects malformed payloads with a trailing has_ipfs byte while preserving the existing serialized form for valid reissues. Refs RavenProject#517
Declare the restricted-asset clear handlers as Qt slots so the existing button connections resolve through the meta-object system. Refs RavenProject#968
This reverts commit fec813c.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Issue #517 asks for investigation of malformed reissue scripts carrying a trailing
00byte after the serialized reissue fields. The parser currently includes the terminalOP_DROPin the deserialization stream and does not verify that the payload is fully consumed, so trailing payload bytes can be ignored.Change
OP_DROP.OP_DROP.The valid serialized reissue format is unchanged. The added regression test keeps the valid empty-IPFS form and verifies that a payload with a trailing
00byte is rejected.Test plan
git diff --checkserialization_testscoverage for a malformed trailing byte.A full Ravencoin build and C++ test binary run were not attempted on the ARM64 development host because the checkout is unconfigured and project policy reserves heavyweight builds for the authorized PC. No local Ravencoin node or mainnet data directory is available to verify whether malformed scripts exist in the wild; maintainers should perform that compatibility check before merge.
Refs #517