Skip to content

Consensus: Reject trailing reissue data #1314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Tabakkui wants to merge 3 commits into
base: develop
Choose a base branch
from
+13 −1
Open

Consensus: Reject trailing reissue data #1314

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2789c79
Consensus: Reject trailing reissue data
Tabakkui Sep 15, 2026
fec813c
GUI: Fix restricted asset clear slots
Tabakkui Sep 15, 2026
d5eb5cf
Revert "GUI: Fix restricted asset clear slots"
Tabakkui Sep 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion src/assets/assets.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -827,13 +827,16 @@ bool ReissueAssetFromScript(const CScript& scriptPubKey, CReissueAsset& reissue,
if (!IsScriptReissueAsset(scriptPubKey, nStartingIndex))
return false;

if (scriptPubKey.empty() || scriptPubKey.back() != OP_DROP)
return false;

CTxDestination destination;
ExtractDestination(scriptPubKey, destination);

strAddress = EncodeDestination(destination);

std::vector<unsigned char> vchReissueAsset;
vchReissueAsset.insert(vchReissueAsset.end(), scriptPubKey.begin() + nStartingIndex, scriptPubKey.end());
vchReissueAsset.insert(vchReissueAsset.end(), scriptPubKey.begin() + nStartingIndex, scriptPubKey.end() - 1);
CDataStream ssReissue(vchReissueAsset, SER_NETWORK, PROTOCOL_VERSION);

try {
Expand All @@ -843,6 +846,9 @@ bool ReissueAssetFromScript(const CScript& scriptPubKey, CReissueAsset& reissue,
return false;
}

if (!ssReissue.empty())
return false;

return true;
}

Expand Down
6 changes: 6 additions & 0 deletions src/test/assets/serialization_tests.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,6 +111,12 @@ BOOST_FIXTURE_TEST_SUITE(serialization_tests, BasicTestingSetup)
BOOST_CHECK_MESSAGE(serializedAsset2.nAmount == 100000000, "Amount weren't equal");
BOOST_CHECK_MESSAGE(serializedAsset2.strIPFSHash == "", "IPFSHash wasn't equal");

// Reject trailing data in a reissue payload.
scriptPubKey.insert(scriptPubKey.end() - 1, 0x00);
CReissueAsset malformedAsset;
BOOST_CHECK_MESSAGE(!ReissueAssetFromScript(scriptPubKey, malformedAsset, address),
"Malformed reissue payload was accepted");

// Txid Hash instead of IPFS
CReissueAsset reissue3(name, 100000000, 0, 0, DecodeAssetData("9c2c8e121a0139ba39bffd3ca97267bca9d4c0c1e84ac0c34a883c28e7a912ca"));
scriptPubKey = GetScriptForDestination(dest);
Expand Down