Repository navigation
fix: restore system proxy support, correct rust-version, add delivery tests - #40
Merged
Merged
Conversation
… tests - Turn reqwest's `charset`, `http2` and `system-proxy` features back on. Turning off reqwest's default features for the TLS flags (#34) also dropped these, so the plugin ignored the macOS and Windows proxy settings. TLS is still chosen with default-tls / rustls-tls / native-tls, and rustls builds still don't pull in OpenSSL. - Set rust-version to 1.85.0: reqwest 0.13 and rand 0.10 need it. - Add tests for event delivery (batches of 25, 5xx and network failures kept for the next flush, 4xx dropped, event format, polling) and App Key validation, and run `cargo test` in CI. - CI fails if a default or rustls-tls build for Linux or Android pulls in OpenSSL. - Document delivery, proxies and the TLS backend features in the README and llms.txt. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
system-proxy,http2andcharset, so since 1.1.0 the plugin has ignored the macOS and Windows proxy settings. Those three are now listed explicitly next tojson. Only the TLS default stays off, sodefault-tls/rustls-tls/native-tlswork exactly as Add feature flags for TLS selection #34 intended.rust-versionis now 1.85.0. It said 1.81.0, but reqwest 0.13.4 and rand 0.10 need 1.85.cargo teststep (CI only rancargo checkbefore):rustls-tlsbuild for Linux or Android hasopenssl-sysornative-tlsin its dependency tree.#34's goal still holds
TLS and proxy crates in the dependency tree (
cargo tree -e normal --target <t>). Before → after:rustls-tlsnative-tlsOpenSSL still only appears with
native-tlson Linux and Android. The proxy crates are only pulled in on macOS and Windows.Test plan
cargo teston stable: 8 passedcargo teston Rust 1.85 (withCARGO_RESOLVER_INCOMPATIBLE_RUST_VERSIONS=fallback): builds and passescargo checkwith--no-default-features --features rustls-tlsand with--features native-tlsnative-tlsNote for #38
src/test_server.rsis #38's test server without the error endpointurlfield, plusserver_on(listener, statuses). The network-failure test needs it to serve on a port the first flush found closed. When #38 rebases, keep itsurlfield and addserver_on.CHANGELOG.md([Unreleased]) and the[dev-dependencies]section ofCargo.tomlwill also need small manual merges; a dry-run merge shows everything else merges cleanly.🤖 Generated with Claude Code