Fix unit conversion for heat of combustion in setCustomFuelModel() - #73
Open
j-tenny wants to merge 1 commit into
Open
Fix unit conversion for heat of combustion in setCustomFuelModel()#73j-tenny wants to merge 1 commit into
j-tenny wants to merge 1 commit into
Conversation
No unit conversion was happening on heat of combustion when creating a custom fuel model. Thus, if creating a custom fuel model with metric inputs, reaction intensity, spread rate, etc was off by a factor of 2.3. Added conversion for this value and tested compiling and basic run.
|
Hi @nwagenbrenner - would you or someone from the Fire Lab mind taking a look at this PR before we merge it? We'd appreciate any input you have from the fire science side. Thanks! |
nwagenbrenner
self-requested a review
September 10, 2026 22:02
Member
|
This looks good as well! |
|
Great, thank you!! @rjsheperd - Could you please also merge this one as well? Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No unit conversion was happening on heat of combustion when creating a custom fuel model. Thus, if creating a custom fuel model with metric inputs, reaction intensity, spread rate, etc was off by a factor of 2.3. Added conversion for this value and tested compiling and basic run.
Same as second commit from PR #72, but was asked to separate into two PRs.