Fixed SAVR unit conversion in BehaveUnits.cpp - #72
Conversation
Unit conversions for surface area to volume ratio were backwards. Moved constants from 'toBaseUnits' to 'fromBaseUnits' and vice-versa.
No unit conversion was happening on heat of combustion when creating a custom fuel model. Thus, if creating a custom fuel model with metric inputs, reaction intensity, spread rate, etc was off by a factor of 2.3. Added conversion for this value and tested compiling and basic run.
|
Fix unit conversion for heat of combustion in setCustomFuelModel() After fixing previous issue, noticed that no unit conversion was happening on heat of combustion when creating a custom fuel model. Thus, if creating a custom fuel model with metric inputs, reaction intensity, spread rate, etc was off by a factor of 2.3. Added conversion for this value and tested compiling and basic run. |
|
Hi @j-tenny, thanks for your submission! We've received the PR and will take a look. We'll follow up here if we have questions or feedback. |
|
Hi @j-tenny, I talked this through with the development team, and we think it would be best to split this into two separate PR's. This will make each change easier to review. Would you mind splitting it up into two PRs. We can then look at each one separately. Thanks! |
2 participants
Unit conversions for surface area to volume ratio were backwards. Moved constants from 'toBaseUnits' to 'fromBaseUnits' and vice-versa. Tested and working properly now.