Fixed SAVR unit conversion in BehaveUnits.cpp - #74
Open
j-tenny wants to merge 1 commit into
Open
Conversation
Unit conversions for surface area to volume ratio were backwards. Moved constants from 'toBaseUnits' to 'fromBaseUnits' and vice-versa.
|
Hi @nwagenbrenner - would you or someone from the Fire Lab mind taking a look at this PR before we merge it? We'd appreciate any input you have from the fire science side. Thanks! |
nwagenbrenner
self-requested a review
September 10, 2026 22:01
Member
|
This is a valid fix and looks good. Thanks! |
|
Great, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unit conversions for surface area to volume ratio were backwards. This was a problem for creating custom fuel models with metric inputs. When converting units from "per centimeter" to "per foot", the value should get bigger. Moved constants from 'toBaseUnits' to 'fromBaseUnits' and vice-versa.
This is the same as the first commit in PR #72, but I was asked to separate the commits into two PRs.