Skip to content

fix(auth): Adds GITHUB_OAUTH_ISSUER to nextauth.js to unblock login via Github #617

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rdavila00 wants to merge 4 commits into
base: main
Choose a base branch
from
Open

fix(auth): Adds GITHUB_OAUTH_ISSUER to nextauth.js to unblock login via Github #617

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7197ae9
adding graphify output to gitignore
rdavila00 Sep 30, 2026
7299265
fixing ignore for graphify out
rdavila00 Sep 30, 2026
f8c13e7
fixing github auth issue
rdavila00 Sep 30, 2026
eea5073
removing comment
rdavila00 Sep 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .env.sample
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ NEXTAUTH_SECRET=abcdefghijlmnopqrstuvwxyz

GITHUB_ID=
GITHUB_SECRET=
GITHUB_OAUTH_ISSUER=https://github.com/login/oauth

#If you are contributing to the project and using Github OAuth above, then feel free to not set the below variables.
#On production this should be set to FCC's auth0 tenant.
Expand Down
5 changes: 4 additions & 1 deletion .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@ build/Release
node_modules/
jspm_packages/


# TypeScript v1 declaration files
typings/

Expand Down Expand Up @@ -145,4 +146,6 @@ yarn-error.log*
data/challengeMap.json

# Docker local overrides
docker-compose.override.yml
docker-compose.override.yml

/graphify-out
1 change: 1 addition & 0 deletions pages/api/auth/[...nextauth].js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,7 @@ if (process.env.GITHUB_OAUTH_PROVIDER_ENABLED == 'true') {
GithubProvider({
clientId: process.env.GITHUB_ID,
clientSecret: process.env.GITHUB_SECRET,
issuer: process.env.GITHUB_OAUTH_ISSUER,
// Enable dangerous account linking in dev environment
...(process.env.DANGEROUS_ACCOUNT_LINKING_ENABLED == 'true'
? { allowDangerousEmailAccountLinking: true }
Expand Down