feat(android-nav3): [Android Nav3 3] Track navigation state transitions - #6131
Merged
0xadam-brown merged 13 commits intoSep 25, 2026
Merged
0xadam-brown merged 13 commits into
0xadam-brown merged 13 commits into
Conversation
0xadam-brown
requested review from
adinauer,
markushi,
romtsn and
runningcode
as code owners
September 18, 2026 10:28
This was referenced Sep 18, 2026
Contributor
|
This was referenced Sep 18, 2026
📲 Install BuildsAndroid
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
0xadam-brown
force-pushed
the
feat/sentry-nav3-effect-3-observer
branch
from
September 18, 2026 11:00
729cbc7 to
a0704f7
Compare
0xadam-brown
force-pushed
the
feat/sentry-nav3-effect-2-routes
branch
from
September 18, 2026 11:28
7ea1f4c to
dc5546c
Compare
0xadam-brown
force-pushed
the
feat/sentry-nav3-effect-3-observer
branch
from
September 18, 2026 11:28
a0704f7 to
6a2c118
Compare
0xadam-brown
force-pushed
the
feat/sentry-nav3-effect-2-routes
branch
from
September 18, 2026 12:38
dc5546c to
b0eb957
Compare
0xadam-brown
force-pushed
the
feat/sentry-nav3-effect-3-observer
branch
from
September 18, 2026 12:38
9e615c3 to
7e1db9e
Compare
0xadam-brown
commented
Sep 18, 2026
0xadam-brown
added
the
deep-dive
7 tasks
0xadam-brown
force-pushed
the
feat/sentry-nav3-effect-3-observer
branch
from
September 24, 2026 08:10
56bd4d4 to
fee0b6c
Compare
0xadam-brown
force-pushed
the
feat/sentry-nav3-effect-2-routes
branch
from
September 24, 2026 08:10
b0eb957 to
4038ff4
Compare
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
0xadam-brown
force-pushed
the
feat/sentry-nav3-effect-2-routes
branch
from
September 24, 2026 08:18
4038ff4 to
01c0ad0
Compare
0xadam-brown
force-pushed
the
feat/sentry-nav3-effect-3-observer
branch
from
September 24, 2026 08:18
fee0b6c to
acf57d4
Compare
Base automatically changed from
feat/sentry-nav3-effect-2-routes
to
feat/sentry-nav3-effect-stack
September 24, 2026 16:24
0xadam-brown
force-pushed
the
feat/sentry-nav3-effect-3-observer
branch
from
September 24, 2026 16:33
acf57d4 to
b0cf97d
Compare
Add the observer layer that turns Navigation 3 back stack changes into breadcrumbs, scope state, and navigation transactions. This is also the point where the module starts carrying generated BuildConfig version metadata and its first non-empty API snapshot.
Keep the hint internal for the current stack, but mark it experimental ahead of the follow-on public surface work. Also rename the key and field to match the Android hint naming pattern.
Remove BackStackObserver's broad top-level try/catch around navigation updates and cleanup. Keep broad catching at the actual host-callback boundaries in RouteTranslator, where route extractors and later value sanitization can execute arbitrary application code. Those are the places where graceful degradation is justified. Do not keep a second observer-wide catch above that layer. It mostly hides SDK bugs in BackStackObserver itself, and configureScope already catches exceptions thrown from the scope-mutation callback. Dropping the extra wrapper leaves host callback failures isolated where they occur while making internal observer failures easier to surface during testing and dogfooding. Co-Authored-By: OpenAI GPT-5.4 <noreply@openai.com>
Move scope and transaction navigation-context updates out of BackStackObserver into a dedicated private helper. Keep the behavior unchanged while separating the route-to-context binding concern from the observer's change-detection and transaction lifecycle logic. This reduces the observer's surface area and makes the remaining TooManyFunctions pressure easier to address with smaller follow-up extractions. Co-Authored-By: OpenAI GPT-5.4 <noreply@openai.com>
Rename the local BackStackObserver collaborators to a consistent Nav* pattern. These types exist only to simplify the observer's implementation rather than to model stable domain abstractions. Using a shared helper-oriented naming scheme makes that status clearer and keeps the file's private implementation pieces on the same footing. Co-Authored-By: OpenAI GPT-5.4 <noreply@openai.com>
0xadam-brown
force-pushed
the
feat/sentry-nav3-effect-3-observer
branch
from
September 25, 2026 10:07
28691f0 to
76a9013
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 76a9013. Configure here.
runningcode
reviewed
Sep 25, 2026
runningcode
left a comment
runningcode
left a comment
Contributor
There was a problem hiding this comment.
just dropping a quick comment, will review the rest later.
Treat no-op transactions from scopes.startTransaction as 'not started' in BackStackObserver. This prevents ignored or incompatible nav transactions from being bound to the default scope, which could otherwise leave a finished no-op transaction attached and block later real transactions until the next top-of-stack change. Add a regression test proving the observer leaves scope.transaction unset when startTransaction returns NoOpTransaction. Co-Authored-By: OpenAI GPT-5.4 <noreply@openai.com>
runningcode
approved these changes
Sep 25, 2026
runningcode
left a comment
runningcode
left a comment
Contributor
There was a problem hiding this comment.
LGTM. left some comments!
0xadam-brown
merged commit Sep 25, 2026
d825db7
into
feat/sentry-nav3-effect-stack
71 of 77 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Stack (Android Nav3)
📜 Description
Now we wire up the logic for consuming the host app's back stack and emitting finished Sentry data. The class responsible for doing so is
BackStackObserver.It rotates the ambient nav transaction and emits the following Sentry data every time the top of the back stack is updated:
SentryNavOptions.maxCapturedBackStackEntriesBackStackObsever makes use of the
RouteTranslatorfrom #6130 for the actual back stack entry -> raw Sentry data translation.💡 Motivation and Context
With route modeling in place, the next boundary is the state machine that reacts to navigation changes. Keeping that behavior separate makes it easier to review lifecycle and tracing semantics without mixing in Compose effect concerns yet.
addresses: JAVA-274
💚 How did you test it?
📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps
Introduce the Compose-facing effect that owns this observer in application code.
#skip-changelog