Skip to content

feat(android-nav3): [Android Nav3 5] Make SentryNavEffect accessible to sample apps - #6137

Open
0xadam-brown wants to merge 1 commit into
feat/sentry-nav3-effect-4-effectfrom
feat/sentry-nav3-effect-5-effect
Open

0xadam-brown wants to merge 1 commit into
feat/sentry-nav3-effect-4-effectfrom
feat/sentry-nav3-effect-5-effect

Conversation

@0xadam-brown

@0xadam-brown 0xadam-brown commented Sep 21, 2026 •

Copy link
Copy Markdown
Member

PR Stack (Android Nav3)


📜 Description

Make SentryNavEffect public so the Nav3 sample app can consume the API shape we intend to expose.

Still marked as @ApiStatus.Internal until we actually release + include a CHANGELOG.

💡 Motivation and Context

The sample app should validate the actual API host apps will use. Keeping SentryNavEffect
internal blocks that validation, so this PR exposes the effect as the next step in the Nav3 stack.

addresses: JAVA-274

💚 How did you test it?

  • Existing unit tests
  • API dump updated via CI / local verification as needed

📝 Checklist

  • I added GH Issue ID & Linear ID
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • Review from the native team if needed.
  • Public API changes reviewed by another Mobile SDK team member or implemented according to the develop docs spec.

🔮 Next steps

  • Expose the remaining Nav3 public APIs needed by the sample app
  • Add module README and docs

#skip-changelog

⚠️ Merge this PR using a merge commit (not squash). This PR should merge into the effect branch first, then flow back down the chain.

@github-actions

github-actions Bot commented Sep 21, 2026 •

Copy link
Copy Markdown
Contributor
Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against fb26a84

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 323c163. Configure here.

@sentry

sentry Bot commented Sep 21, 2026 •

Copy link
Copy Markdown

📲 Install Builds

Android

🔗 App Name App ID Version Configuration
SDK Size io.sentry.tests.size 8.57.0 (1) release

⚙️ sentry-android Build Distribution Settings

@0xadam-brown 0xadam-brown changed the title feat(android-nav3): [Android Nav3 5] Make SentryNavEffect public feat(android-nav3): [Android Nav3 5] Make SentryNavEffect accessible to sample apps Sep 21, 2026
@0xadam-brown
0xadam-brown force-pushed the feat/sentry-nav3-effect-5-effect branch from 323c163 to 244d0e8 Compare September 24, 2026 08:10
@0xadam-brown
0xadam-brown force-pushed the feat/sentry-nav3-effect-4-effect branch 2 times, most recently from 33771ca to 337d586 Compare September 24, 2026 08:18
@0xadam-brown
0xadam-brown force-pushed the feat/sentry-nav3-effect-5-effect branch from 244d0e8 to e803369 Compare September 24, 2026 08:18
@0xadam-brown
0xadam-brown force-pushed the feat/sentry-nav3-effect-4-effect branch from 337d586 to 8751079 Compare September 24, 2026 16:33
@0xadam-brown
0xadam-brown force-pushed the feat/sentry-nav3-effect-5-effect branch from e803369 to 3f85ec3 Compare September 24, 2026 16:33
@0xadam-brown
0xadam-brown force-pushed the feat/sentry-nav3-effect-4-effect branch from 8751079 to ad04184 Compare September 25, 2026 10:07
@0xadam-brown
0xadam-brown force-pushed the feat/sentry-nav3-effect-5-effect branch 2 times, most recently from 90e3981 to 3110f44 Compare September 25, 2026 12:48
@0xadam-brown 0xadam-brown added the sanity-check PR needs a lightweight review for obvious issues label Sep 25, 2026
@0xadam-brown
0xadam-brown force-pushed the feat/sentry-nav3-effect-4-effect branch from ad04184 to 8a70c21 Compare September 25, 2026 12:50
@0xadam-brown
0xadam-brown force-pushed the feat/sentry-nav3-effect-5-effect branch from 3110f44 to 78d8efc Compare September 25, 2026 12:50

@runningcode runningcode left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good.
Btw, if you aren't merging parts of the stack to master, I think you can just set the visibility correctly in the PR that introduces the class.

@ApiStatus.Internal
@Immutable
internal class SentryNavOptions
public class SentryNavOptions

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: all the public declarations are redundant in this PR. not sure if we have any style guide on that.

@0xadam-brown
0xadam-brown force-pushed the feat/sentry-nav3-effect-4-effect branch from 8a70c21 to 15d7842 Compare September 25, 2026 15:10
@0xadam-brown
0xadam-brown force-pushed the feat/sentry-nav3-effect-5-effect branch from 78d8efc to e0182ff Compare September 25, 2026 15:10
Make SentryNavEffect and related APIs public so they can be called from the Nav3 sample app. For now, keep them marked as @ApiStatus.Internal until we publicly released + include a CHANGELOG entry.
@0xadam-brown
0xadam-brown force-pushed the feat/sentry-nav3-effect-4-effect branch from cfa8248 to 2b40b9d Compare September 25, 2026 15:46
@0xadam-brown
0xadam-brown force-pushed the feat/sentry-nav3-effect-5-effect branch from e0182ff to fb26a84 Compare September 25, 2026 15:46

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

sanity-check PR needs a lightweight review for obvious issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants