feat(android-nav3): [Android Nav3 5] Make SentryNavEffect accessible to sample apps - #6137
Open
0xadam-brown wants to merge 1 commit into
Open
0xadam-brown wants to merge 1 commit into
0xadam-brown wants to merge 1 commit into
Conversation
0xadam-brown
requested review from
adinauer,
markushi,
romtsn and
runningcode
as code owners
September 21, 2026 05:39
9 tasks
Contributor
|
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 323c163. Configure here.
📲 Install BuildsAndroid
|
This was referenced Sep 21, 2026
0xadam-brown
force-pushed
the
feat/sentry-nav3-effect-5-effect
branch
from
September 24, 2026 08:10
323c163 to
244d0e8
Compare
0xadam-brown
force-pushed
the
feat/sentry-nav3-effect-4-effect
branch
2 times, most recently
from
September 24, 2026 08:18
33771ca to
337d586
Compare
0xadam-brown
force-pushed
the
feat/sentry-nav3-effect-5-effect
branch
from
September 24, 2026 08:18
244d0e8 to
e803369
Compare
0xadam-brown
force-pushed
the
feat/sentry-nav3-effect-4-effect
branch
from
September 24, 2026 16:33
337d586 to
8751079
Compare
0xadam-brown
force-pushed
the
feat/sentry-nav3-effect-5-effect
branch
from
September 24, 2026 16:33
e803369 to
3f85ec3
Compare
0xadam-brown
force-pushed
the
feat/sentry-nav3-effect-4-effect
branch
from
September 25, 2026 10:07
8751079 to
ad04184
Compare
0xadam-brown
force-pushed
the
feat/sentry-nav3-effect-5-effect
branch
2 times, most recently
from
September 25, 2026 12:48
90e3981 to
3110f44
Compare
0xadam-brown
force-pushed
the
feat/sentry-nav3-effect-4-effect
branch
from
September 25, 2026 12:50
ad04184 to
8a70c21
Compare
0xadam-brown
force-pushed
the
feat/sentry-nav3-effect-5-effect
branch
from
September 25, 2026 12:50
3110f44 to
78d8efc
Compare
runningcode
approved these changes
Sep 25, 2026
runningcode
left a comment
Contributor
There was a problem hiding this comment.
This looks good.
Btw, if you aren't merging parts of the stack to master, I think you can just set the visibility correctly in the PR that introduces the class.
| @ApiStatus.Internal | ||
| @Immutable | ||
| internal class SentryNavOptions | ||
| public class SentryNavOptions |
Contributor
There was a problem hiding this comment.
nit: all the public declarations are redundant in this PR. not sure if we have any style guide on that.
0xadam-brown
force-pushed
the
feat/sentry-nav3-effect-4-effect
branch
from
September 25, 2026 15:10
8a70c21 to
15d7842
Compare
0xadam-brown
force-pushed
the
feat/sentry-nav3-effect-5-effect
branch
from
September 25, 2026 15:10
78d8efc to
e0182ff
Compare
Make SentryNavEffect and related APIs public so they can be called from the Nav3 sample app. For now, keep them marked as @ApiStatus.Internal until we publicly released + include a CHANGELOG entry.
0xadam-brown
force-pushed
the
feat/sentry-nav3-effect-4-effect
branch
from
September 25, 2026 15:46
cfa8248 to
2b40b9d
Compare
0xadam-brown
force-pushed
the
feat/sentry-nav3-effect-5-effect
branch
from
September 25, 2026 15:46
e0182ff to
fb26a84
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

PR Stack (Android Nav3)
📜 Description
Make
SentryNavEffectpublic so the Nav3 sample app can consume the API shape we intend to expose.Still marked as
@ApiStatus.Internaluntil we actually release + include a CHANGELOG.💡 Motivation and Context
The sample app should validate the actual API host apps will use. Keeping
SentryNavEffectinternal blocks that validation, so this PR exposes the effect as the next step in the Nav3 stack.
addresses: JAVA-274
💚 How did you test it?
📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps
#skip-changelog