Skip to content

test: Fix assertions in TestGraph - #620

Merged
SarahFrench merged 1 commit into
mainfrom
address-whitespace-change-graph-output
Oct 27, 2026
Merged

SarahFrench merged 1 commit into
mainfrom
address-whitespace-change-graph-output

Conversation

@SarahFrench

@SarahFrench SarahFrench commented Oct 27, 2026 •

Copy link
Copy Markdown
Member

Related Issue

Fixes a test failing on main branch in the hashicorp/terraform repo after hashicorp/terraform#39424 was merged.

See: https://github.com/hashicorp/terraform/actions/runs/40484089098

Description

I recently updated the graph command to use views to print output to the terminal. This change often includes an extra newline at the end of output.

Assertions should ignore whitespace at start/end of output. Tests should pick up if the text content of the output changes.

Rollback Plan

  • If a change needs to be reverted, we will roll out an update to the code within 7 days.

Changes to Security Controls

N/A

@austinvalle austinvalle left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TIL that terraform-exec tests run off the CI in terraform 😅

@SarahFrench

Copy link
Copy Markdown
Member Author

TIL that terraform-exec tests run off the CI in terraform 😅

Same here! Also, the head of main in terraform is used to run tests on PRs in terraform-exec 😵

@SarahFrench
SarahFrench merged commit 4bbbd3f into main Oct 27, 2026
107 checks passed
@SarahFrench
SarahFrench deleted the address-whitespace-change-graph-output branch October 27, 2026 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants