Skip to content

test: Fix assertions in TestGraph #620

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SarahFrench merged 1 commit into from
Oct 27, 2026
+7 −1
Merged

test: Fix assertions in TestGraph #620

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion tfexec/internal/e2etest/graph_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ package e2etest

import (
"context"
"strings"
"testing"

"github.com/google/go-cmp/cmp"
Expand All @@ -30,7 +31,10 @@ func TestGraph(t *testing.T) {
t.Fatalf("error running Graph: %s", err)
}

if diff := cmp.Diff(expectedGraphOutput(tfv), graphOutput); diff != "" {
got := strings.TrimSpace(graphOutput)
want := strings.TrimSpace(expectedGraphOutput(tfv))

if diff := cmp.Diff(want, got); diff != "" {
t.Fatalf("Graph output does not match: %s", diff)
}
})
Expand Down Expand Up @@ -114,6 +118,8 @@ func expectedGraphOutput(tfv *version.Version) string {
}

// 1.7.0+
// NOTE: there have been some trailing whitespace changes around v1.18,
// but this is handled in the test by trimming whitespace from both the expected and actual output.
return `digraph G {
rankdir = "RL";
node [shape = rect, fontname = "sans-serif"];
Expand Down
Loading